The default bug view has changed. See this FAQ.

Checkin for Bug 280769 broke AIX tinderbox

VERIFIED FIXED

Status

()

Core
JavaScript Engine
--
major
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: Philip K. Warren, Assigned: Igor Bukanov)

Tracking

({fixed-aviary1.0.8, fixed1.7.13, fixed1.8})

Trunk
Other
AIX
fixed-aviary1.0.8, fixed1.7.13, fixed1.8
Points:
---
Bug Flags:
blocking1.7.13 +
blocking-aviary1.0.8 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
Here is the error from the tinderbox build:

"/home/tbox/sb/tinderbox/AIX_5.1_Clobber/mozilla/js/src/jsregexp.c", line 206.9:
1506-213 (S) Macro name ARG_MAX cannot be redefined.
gmake[4]: *** [jsregexp.o] Error 1
(Reporter)

Comment 1

12 years ago
The conflict appears to be in /usr/include/limits.h (linked to
/usr/include/sys/limits.h):

./sys/limits.h:#define  ARG_MAX         24576
./limits.h:#define      ARG_MAX         24576

I believe a simple:

#ifdef ARG_MAX
#undef ARG_MAX
#endif

in jsregexp.c will fix this issue.
(Reporter)

Updated

12 years ago
Severity: critical → major
(Reporter)

Comment 2

12 years ago
Created attachment 197965 [details] [diff] [review]
Patch v1

This fixes the issue.
Attachment #197965 - Flags: superreview?(brendan)
Attachment #197965 - Flags: review?(mrbkap)
Comment on attachment 197965 [details] [diff] [review]
Patch v1

It's too bad we need this :-/. r=mrbkap
Attachment #197965 - Flags: review?(mrbkap) → review+
You're going to want to check this in on the branch as well.
Philip, only one review is needed in js/src (and brendan tends to rubber-stamp
these sorts of fixes anyway), so I think you can go ahead and check this in.
(Assignee)

Comment 6

12 years ago
Created attachment 198154 [details] [diff] [review]
No need for ARG_MAX

ARG_MAX was used only to define OFFSET_MAX so the patch simply use in
OFFSET_OFF the definition ARG_MAX removing the latter.
Attachment #198154 - Flags: review?(mrbkap)
Comment on attachment 198154 [details] [diff] [review]
No need for ARG_MAX

Yeah, I like this one better.
Attachment #198154 - Flags: review?(mrbkap) → review+
Comment on attachment 198154 [details] [diff] [review]
No need for ARG_MAX

jsregexp.c should really use standard bytecode macros anyway.  Some other time.
 This should be checked into trunk and branch, it's a good porting fix.

/be
Attachment #198154 - Flags: superreview+
Attachment #198154 - Flags: approval1.8b5+

Updated

12 years ago
Assignee: general → igor.bukanov
Fix checked in on MOZILLA_1_8_BRANCH and trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Updated

12 years ago
Flags: testcase-
(Reporter)

Updated

11 years ago
Status: RESOLVED → VERIFIED
Blocks: 280769
Nominating, needed if bug 280769 is taken
Flags: blocking1.7.13?
Flags: blocking-aviary1.0.8?
Flags: blocking1.7.13?
Flags: blocking1.7.13+
Flags: blocking-aviary1.0.8?
Flags: blocking-aviary1.0.8+
Fix incorporated into the backported patch for bug 280769
Keywords: fixed-aviary1.0.8, fixed1.7.13
(Reporter)

Updated

11 years ago
Attachment #197965 - Flags: superreview?(brendan)
You need to log in before you can comment on or make changes to this bug.