310644 - Firefox/1.4.1 app provided ext's have minVersion and maxVersion 1.4

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Anbo Motohiko]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; ja-JP; rv:1.9a1) Gecko/20050930 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; ja-JP; rv:1.9a1) Gecko/20050930 Firefox/1.6a1

After bumped Firefox version to 1.4.1, extensions that are compatible with
Firefox 1.5 Beta 1 (internal version: 1.4) are disabled by app.

I tested with pacifica-mozilla1.8 buildID: 2005093018.

Third digit is used for security/minor update, so 1.4.1 should be compatible
with 1.4.

Reproducible: Always

Steps to Reproduce:
1. Download latest builds.
2. Run Firefox with new profile.
3. See extension manager.

Actual Results:  
DOM Inspector, Reporter and Talkback are disabled:
'Disabled - not compatible with Firefox 1.4.1'

Expected Results:  
Enabled normally.

Comment 1

[Kevin Brosnan]

Well the build you are currently using is Firefox 1.6a1. This is very differnt
than Firefox 1.5 beta 1 which has an internal version of 1.4. You likely want a
build from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/

Comment 2

[Anbo Motohiko]

(In reply to comment #1)
> Well the build you are currently using is Firefox 1.6a1. This is very differnt
> than Firefox 1.5 beta 1 which has an internal version of 1.4. You likely want a
> build from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/

I posted this bug from latest-trunk but I wrote:
> I tested with pacifica-mozilla1.8 buildID: 2005093018.

Comment 3

[Robert Strong (they/them - no direct email)]

I am quite certain this is a build config problem... the app provided extensions
get their target application version info during the build process and if the
files haven't changed they aren't updated with the new version data.

Comment 4

[Robert Strong (they/them - no direct email)]

Confirmed on a linux build... the install.rdf's for the app provided extensions
still have targetApplication minVersion / maxVersion of 1.4

Comment 5

[Anbo Motohiko]

(In reply to comment #3)
> I am quite certain this is a build config problem... the app provided extensions
> get their target application version info during the build process and if the
> files haven't changed they aren't updated with the new version data.
Hmm...

I said 1.4.1 should be compatible with 1.4.
Extensions compatible with Firefox 1.0 are compatible with Firefox 1.0.7. OK?
I think this is a regression.

'Steps to Reproduce' in comment #0 confuses you. That's my mistake.

In compatibility check, EM should ignore third digit of application version string.

Comment 6

[Benjamin Smedberg]

1) Policy decision: the extension version is going to be revved with all 1.4.x
and 1.5.x releases, so extensions will need to be updated specifically for each
release. This decision was made based on the history of the 1.0 branch
accidentally or intentionally making changes that broke extensions and
extensions having no way of telling the various 1.0.x versions apart.

2) our build system should be setting the minverxion/maxversion of the "builtin"
extensions properly. If it's not that's a bug to fix.

Comment 7

[Benjamin Smedberg]

Bug as filed (#1) WONTFIX. Problem #2 WFM in today's nightlies.

Comment 8

[Darin Fisher]

> 1) Policy decision: the extension version is going to be revved with all 
> 1.4.x and 1.5.x releases, so extensions will need to be updated specifically 
> for each release. This decision was made based on the history of the 1.0 
> branch accidentally or intentionally making changes that broke extensions and
> extensions having no way of telling the various 1.0.x versions apart.

In what forum was this policy decision agreed upon?  I think it means that all
third-party extensions will need to set their maxVersion to 1.5.999, which
basically defeats the purpose of this field.  It's not a stable branch if it
isn't stable, so why do you need this?  If we're going to go this route, then we
had better document this behavior LOUD and CLEAR so there is no confusion,
otherwise you are going to just have a bunch of angry extension developers
yelling at you when 1.5.1 breaks them.


> 2) our build system should be setting the minverxion/maxversion of the 
> "builtin" extensions properly. If it's not that's a bug to fix.

Yes, they do.  They just set min/maxVersion equal to the version of the application.

Comment 9

[Robert Strong (they/them - no direct email)]

Just a note... they do just set min/maxVersion equal to the version of the
application but this didn't get applied to the install.rdf's in the hourly
builds immediately following the change.

Comment 10

[Benjamin Smedberg]

The problem with extension versions was caused by incomplete dependencies in our
build system (thus fixed by the nightly clean builds). The other policy question
is in review.