310651 - Full URL not displayed after cmd/ctrl/shift-enter and switching tabs

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

Seems similar to bug 287996. Also regressed with the checkin for bug 272002 on
20050215. Tested on Firefox 1.4 20050930 mac.

Steps:
Type in the domain to complete with www and .com
Press cmd/ctrl-enter and switch to a new tab and back quickly
Location bar shows the domain without www and .com

Comment 1

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050930
Firefox/1.6a1 ID:2005093016

Works for me. The URL is updated once the page loads.

Comment 2

[Ed Lee :Mardak]

I guess I should have put more emphasis on *quickly* indicating that it would
display the correct url when the page loads.

You can try it with "agadak" shift-enter.. it should always take a couple
seconds to load (sleeps 1 second before sending the page).

Comment 3

[Ed Lee :Mardak]

A patch for this issue would probably be similar to the one that fixed bug 287996?

From patch comment.. "Completing a result should simulate the user typing the
result, so fire an input event."

Comment 4

[Asa Dotzler [:asa]]

can you all figure out when this regressed? thanks.

Comment 5

[Ed Lee :Mardak]

This regressed with the checkin for bug 272002 on 20050215. (Build on 20050215
still works while the new build on 20050216 fails.)

Comment 6

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051012
Firefox/1.6a1 ID:2005101212

I still can't reproduce this. Are you testing this in a clean profile? Could be
Mac-only, too...

Comment 7

[Ed Lee :Mardak]

I can reproduce this with a 20051013 windows build as well as mac on clean profiles.

Perhaps it has something to do with directly setting the autocomplete's value
property directly?

http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.js#2155

Brian recently added a setTextValue (private?) method to the autocomplete that
triggers a UI event to help fix bug 287996. Perhaps instead of doing something
like..

gURLBar.value = getShortcutOrURI(url, aPostDataRef);

it should do something similar to a setTextValue.

Comment 8

[Andrew Schultz]

==> firefoz

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 315075 has been marked as a duplicate of this bug. ***

Comment 10

[Ed Lee :Mardak]

Attachment: Update gBrowser's userTypedValue

One possibility is to update gBrowser.userTypedValue, but I suppose the bigger issue is why doesn't it get updated in this situation?

Another way to make this bug go away is to trigger an input UIEvent on gURLBar.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 361538 has been marked as a duplicate of this bug. ***

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 240052 [details] [diff] [review]
Update gBrowser's userTypedValue

Sorry for taking so long to review this, Edward. One little nit: add a newline before the added lines. I can do that and check this in for you.

Comment 13

[Nickolay_Ponomarev]

Attachment: as checked in

Comment 14

[Nickolay_Ponomarev]

mozilla/browser/base/content/browser.js  1.773