310696 - regression: View Source (and View Selection Source) window title is broken

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Asaf Romano (gone)]

seen on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051001
Firefox/1.4.1

The view source window title is prefixed with "view-source:"

Looks like a regression from bug 304388.

Comment 1

[Asaf Romano (gone)]

ditto for "View Selection Source".

Comment 2

[Asaf Romano (gone)]

Attachment: branch-only patch

I'm going to do something a bit more Right for the trunk, but for the branch,
this is pretty safe.

Comment 3

[Asaf Romano (gone)]

Attachment: parallel (branch only) fix for thunderbird

Comment 4

[Daniel Veditz [:dveditz]]

Attachment: a better approach?

I think this is a better, more general, fix.

Comment 5

[Scott MacGregor]

Comment on attachment 198197 [details] [diff] [review]
parallel (branch only) fix for thunderbird

minusing this pending resolution on dan's suggested fix instead.

Comment 6

[Daniel Veditz [:dveditz]]

Attachment: prepath in titlebar only if there's a host

The same as the previous patch with some comment corrections, and a change in
the xpfe tabbrowser that I forgot to carry over from the toolkit version.

The 1.0 branch has this same bug and apparently no one noticed. I guess
view-source is only used by developer types who had already abandoned that
branch in favor of the trunk by time we made the fix.

Comment 7

[[e-mail]]

Don't you have to check for the host of the exposed URI, in case of wyciwyg?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 198251 [details] [diff] [review]
prepath in titlebar only if there's a host

Yeah, what Neil said.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 198251 [details] [diff] [review]
prepath in titlebar only if there's a host

doesn't seem to be ready and we're entering lockdown.

Comment 10

[Daniel Veditz [:dveditz]]

Attachment: check host *after* wyciwyg fixup

Carrying over mconnor's r+

Comment 11

[Scott MacGregor]

Comment on attachment 198350 [details] [diff] [review]
check host *after* wyciwyg fixup

Neil, bz is away until tomorrow afternoon. Can you fill in for us with a review
for this?

Comment 12

[[e-mail]]

Comment on attachment 198350 [details] [diff] [review]
check host *after* wyciwyg fixup

Sorry I didn't see this before, mail server outage :-(

>+                nsCAutoString host;
>                 nsCAutoString prepath;
>+                tmpuri->GetHost(host);
>                 tmpuri->GetPrePath(prepath);
>-                if (!prepath.IsEmpty()) {
>+                if (!host.IsEmpty()) {
Nit: Could move the prepath code inside the condition.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 198350 [details] [diff] [review]
check host *after* wyciwyg fixup

moving request to 1.8rc1 since 1.8b5 has shipped.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 198350 [details] [diff] [review]
check host *after* wyciwyg fixup

not major enough for this late in the game.

Comment 15

[Daniel Veditz [:dveditz]]

fix checked into trunk.

Comment 16

[Anbo Motohiko]

How about MOZILLA_1_8_BRANCH?

Comment 17

[:Gavin Sharp [email: [e-mail]]]

mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml 	1.126.2.19
mozilla/toolkit/content/widgets/tabbrowser.xml 	1.103.2.39
mozilla/xpfe/appshell/src/nsContentTreeOwner.cpp 	1.80.8.8