Closed Bug 310754 Opened 19 years ago Closed 19 years ago

Check stroke-dasharray before handoff to renderer

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: tor, Assigned: tor)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

stroke-dasharray checking
3.16 KB, patch
jwatt
: review+
asa
: approval1.8b5+
Details | Diff | Splinter Review 
Check the stroke-dasharray for negative numbers or total zero length, both of
which will cause cairo to stop rendering.

        Attachment #198190 -
        Flags: review?(jonathan.watt)

    
    

    
  
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

Nice. r=me

        Attachment #198190 -
        Flags: review?(jonathan.watt) → review+

    
    

    
  
Checked in on trunk.


    
    

    
  
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

Specification compliance bug, and prevents us from handing invalid data to the
renderer.  Minimal risk.

        Attachment #198190 -
        Flags: approval1.8b5?
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

last day for non-critical changes.

        Attachment #198190 -
        Flags: approval1.8b5? → approval1.8b5+

    
    

    
  
Checked in on branch.

Keywords: fixed1.8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: