Last Comment Bug 310754 - Check stroke-dasharray before handoff to renderer
: Check stroke-dasharray before handoff to renderer
Status: RESOLVED FIXED
: fixed1.8
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: tor
: Hixie (not reading bugmail)
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-01 21:44 PDT by tor
Modified: 2005-10-04 08:26 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
stroke-dasharray checking (3.16 KB, patch)
2005-10-01 21:44 PDT, tor
jwatt: review+
asa: approval1.8b5+
Details | Diff | Splinter Review

Description tor 2005-10-01 21:44:06 PDT
Check the stroke-dasharray for negative numbers or total zero length, both of
which will cause cairo to stop rendering.
Comment 1 tor 2005-10-01 21:44:52 PDT
Created attachment 198190 [details] [diff] [review]
stroke-dasharray checking
Comment 2 Jonathan Watt [:jwatt] 2005-10-02 07:36:12 PDT
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

Nice. r=me
Comment 3 tor 2005-10-02 12:27:09 PDT
Checked in on trunk.
Comment 4 tor 2005-10-02 12:27:53 PDT
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

Specification compliance bug, and prevents us from handing invalid data to the
renderer.  Minimal risk.
Comment 5 Asa Dotzler [:asa] 2005-10-03 10:49:10 PDT
Comment on attachment 198190 [details] [diff] [review]
stroke-dasharray checking

last day for non-critical changes.
Comment 6 tor 2005-10-03 13:38:26 PDT
Checked in on branch.

Note You need to log in before you can comment on or make changes to this bug.