310982 - Remove the 'browserbugmessage' parameter completely

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

This parameter is only used in code-error.html.tmpl and user-error.html.tmpl. It
doesn't give any useful information and editing these two templates directly
would be even better than setting this parameter.


(22:38:25) LpSolit: justdave: we could even remove the 'browserbugmessage' param
completely from the code
(22:38:37) justdave: probably
(22:38:55) justdave: it doesn't seem to have much use except for historical
purposes :)
[...]
(22:45:05) LpSolit: joel: but I think you agree with me that
Param('browserbugmessage') doesn't help and is useless?
(22:45:22) joel: yes

Comment 1

[Joel Peshkin]

LpSolit	would you approve a patch which removes it? ;)
	joel	LpSolit: I think I would reather see it assume that, if the knob is not
defined, the user wanted to leave the status alone.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Joel Peshkin]

Comment on attachment 198351 [details] [diff] [review]
patch, v1

r=joel by inspection

Comment 4

[Frédéric Buclin]

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.167; previous revision: 1.166
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v
 <--  code-error.html.tmpl
new revision: 1.58; previous revision: 1.57
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.130; previous revision: 1.129
done