Closed Bug 311019 Opened 15 years ago Closed 15 years ago

label bound to model doesn't work for choices inside of select

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

Details

(Keywords: fixed1.8)

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

<xf:select ref="/example/select">
  <xf:label>Flavors</xf:label>
  <xf:choices>
    <!-- You cannot see the label -->
    <xf:label ref="/example/label"/>
    <xf:item>
      <xf:label ref="/example/label"/>
      <xf:value>v</xf:value>
  </xf:choices>
</xf:select>

It is true for <select appearance="compact"/> and <select appearance="full"/>.

Error code lines:

http://lxr.mozilla.org/mozilla/source/extensions/xforms/resources/content/select.xml#334
http://lxr.mozilla.org/mozilla/source/extensions/xforms/resources/content/select.xml#645

Reproducible: Always
For bug fixing label control can realize textValue property like it proposes
nsIXFormsLabelElement interface.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: label binded to model doesn't work for choises inside of select → label bound to model doesn't work for choices inside of select
Attached file Testcase
Attached patch patch (obsolete) — Splinter Review
Attachment #198423 - Flags: review?(allan)
Attached patch patchSplinter Review
Attachment #198423 - Attachment is obsolete: true
Attachment #198424 - Flags: review?(allan)
Assignee: aaronr → surkov
OS: Windows 2000 → All
Hardware: PC → All
Attachment #198423 - Flags: review?(allan)
Comment on attachment 198424 [details] [diff] [review]
patch

Seems like a good plan to clone them instead. But I do not know if there was a
reason for not to. Doron'll answer that I guess :)

r=me
Attachment #198424 - Flags: review?(doronr)
Attachment #198424 - Flags: review?(allan)
Attachment #198424 - Flags: review+
Label can contain arbitrary tags. If label will be cloned then choice label can
have custom look. For example:

<xf:choices>
    <xf:label><span style="color: blue">It's a label</span></xf:label>
    <xf:item
Attachment #198424 - Flags: review?(doronr) → review+
checked into trunk
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Reopening bug since the patch hasn't been checked into the branch, yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
checked into branch.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.