311055 - Allow to build firefox (and thunderbird) with --enable-libxul

Status: RESOLVED DUPLICATE of bug 311735

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; ja-JP; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; ja-JP; rv:1.7.10) Gecko/20050717 Firefox/1.0.6

As for now it is impossible to build firefox and thunderbird with the
--enable-libxul option. Please allow this setup (patch will be attached)

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 198449 [details] [diff] [review]
Patch

FWIW, I really don't want this to actually happen except for testing: I don't
want random libxuls floating around with the app-specific ifdefs.

Comment 3

[Mike Hommey [:glandium]]

That's still a first step for #299997. BTW, what exactly differ between apps'
libxul and xulrunner's ?

Comment 4

[Benjamin Smedberg]

Are you working on bug 299997?

Comment 5

[Mike Hommey [:glandium]]

Not in a very near future, but soonish, if nobody does it before.

Comment 6

[Benjamin Smedberg]

Are you going to land this? If not soon, I'm going to fix this differently in bug 311735.

Comment 7

[Mike Hommey [:glandium]]

what do you mean ? do i need to do something ?

Comment 8

[Benjamin Smedberg]

Yes, you are responsible for getting your patches landed. You can ask me to do it (I can't until Tuesday probably), or someone on irc.mozilla.org #developers

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

AFAIK this has been fixed by Benjamin in the other bug.
I'll close this and if I'm wrong please forgive me and reopen the bug.

*** This bug has been marked as a duplicate of 311735 ***