Bogus assertions, and tspan attributes x/y/dx/dy aren't live

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: jwatt, Assigned: tor)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
 
(Reporter)

Comment 1

12 years ago
Created attachment 198451 [details]
testcase

We have two problems. First, we're throwing bogus assertions during
construction and destruction of tspan elements if they don't have an x or a y
attribute. Second, the x/y/dx/dy attributes aren't live on tspan. This testcase
demonstrates both these problems.

The reason we're throwing assertions is because in nsSVGTSpanFrame::Init() and
nsSVGTSpanFrame::~nsSVGTSpanFrame() GetY is returning nsnull. As a result
NS_ADD_SVGVALUE_OBSERVER and NS_REMOVE_SVGVALUE_OBSERVER assert.
(Assignee)

Comment 2

12 years ago
Created attachment 198456 [details] [diff] [review]
live tspan x/y/dx/dy
Assignee: general → tor
Status: NEW → ASSIGNED
(Assignee)

Comment 3

12 years ago
Created attachment 198461 [details] [diff] [review]
add null checks
Attachment #198456 - Attachment is obsolete: true
Attachment #198461 - Flags: review?(alex)

Comment 4

12 years ago
Comment on attachment 198461 [details] [diff] [review]
add null checks

r=afri
Attachment #198461 - Flags: review?(alex) → review+
(Assignee)

Comment 5

12 years ago
Checked in on trunk.
(Assignee)

Comment 6

12 years ago
Comment on attachment 198461 [details] [diff] [review]
add null checks

DOM compliance issue, low risk.
Attachment #198461 - Flags: approval1.8rc1?

Comment 7

12 years ago
Comment on attachment 198461 [details] [diff] [review]
add null checks

too late for non-critical changes.
Attachment #198461 - Flags: approval1.8rc1? → approval1.8rc1-
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.