311063 - Bogus assertions, and tspan attributes x/y/dx/dy aren't live

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: testcase

We have two problems. First, we're throwing bogus assertions during
construction and destruction of tspan elements if they don't have an x or a y
attribute. Second, the x/y/dx/dy attributes aren't live on tspan. This testcase
demonstrates both these problems.

The reason we're throwing assertions is because in nsSVGTSpanFrame::Init() and
nsSVGTSpanFrame::~nsSVGTSpanFrame() GetY is returning nsnull. As a result
NS_ADD_SVGVALUE_OBSERVER and NS_REMOVE_SVGVALUE_OBSERVER assert.

Comment 2

[tor]

Attachment: live tspan x/y/dx/dy

Comment 3

[tor]

Attachment: add null checks

Comment 4

[Alex Fritze]

Comment on attachment 198461 [details] [diff] [review]
add null checks

r=afri

Comment 5

[tor]

Checked in on trunk.

Comment 6

[tor]

Comment on attachment 198461 [details] [diff] [review]
add null checks

DOM compliance issue, low risk.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 198461 [details] [diff] [review]
add null checks

too late for non-critical changes.