Closed
Bug 311063
Opened 19 years ago
Closed 19 years ago
Bogus assertions, and tspan attributes x/y/dx/dy aren't live
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: tor)
Details
Attachments
(2 files, 1 obsolete file)
|
690 bytes,
image/svg+xml
|
Details | |
|
3.70 KB,
patch
|
alex
:
review+
asa
:
approval1.8rc1-
|
Details | Diff | Splinter Review |
testcase
|
Reporter | |
Comment 1•19 years ago
|
||
We have two problems. First, we're throwing bogus assertions during construction and destruction of tspan elements if they don't have an x or a y attribute. Second, the x/y/dx/dy attributes aren't live on tspan. This testcase demonstrates both these problems. The reason we're throwing assertions is because in nsSVGTSpanFrame::Init() and nsSVGTSpanFrame::~nsSVGTSpanFrame() GetY is returning nsnull. As a result NS_ADD_SVGVALUE_OBSERVER and NS_REMOVE_SVGVALUE_OBSERVER assert.
Attachment #198456 -
Attachment is obsolete: true
Attachment #198461 -
Flags: review?(alex)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 198461 [details] [diff] [review] add null checks r=afri
Attachment #198461 -
Flags: review?(alex) → review+
Comment on attachment 198461 [details] [diff] [review] add null checks DOM compliance issue, low risk.
Attachment #198461 -
Flags: approval1.8rc1?
|
||
Comment 7•19 years ago
|
||
Comment on attachment 198461 [details] [diff] [review] add null checks too late for non-critical changes.
Attachment #198461 -
Flags: approval1.8rc1? → approval1.8rc1-
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•