311074 - NSS build fails when building from readonly sources

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Benjamin Smedberg]

When I'm building from readonly sources, the NSS build fails on the "clean"
target of coreconf/nsinstall because it tries to delete "nfspwd". I'm not really
sure why we have both "nfspwd" and "nfspwd.pl" in the tree, but the clean target
should definitely not be removing source files.

Comment 1

[Benjamin Smedberg]

Attachment: Don't do the weird nfspwd thing

Comment 2

[Wan-Teh Chang]

Comment on attachment 198459 [details] [diff] [review]
Don't do the weird nfspwd thing

The definition of PLSRCS should also be removed.

Comment 3

[Benjamin Smedberg]

WTC, can you checkin the appropriate fix? I'm not sure what of trunk/branches
this belongs on (or even how the NSS branching system works).

Comment 4

[Wan-Teh Chang]

Attachment: Don't add nfspwd to TARGETS (as checked in)

This patch is what I checked in on the NSS trunk.
This change will eventually appear on the Mozilla
trunk (estimate: in a few weeks).

Checking in Makefile;
/cvsroot/mozilla/security/coreconf/nsinstall/Makefile,v  <--  Makefile
new revision: 1.10; previous revision: 1.9
done

Comment 5

[Wan-Teh Chang]

Attachment: cvs remove the obsolete nfspwd Perl script

nfspwd.pl and nfspwd are Perl scripts that only worked
on the old Netscape intranet.  Since that network no
longer existed, these scripts are obsolete now and
should be cvs removed.	In makefiles nfspwd should be
replaced by the regular pwd command.

Comment 6

[Robert Relyea]

Comment on attachment 198639 [details] [diff] [review]
cvs remove the obsolete nfspwd Perl script

r+ relyea

Comment 7

[Wan-Teh Chang]

nfspwd and nfspwd.pl removed from CVS.

Checking in OS2.mk;
/cvsroot/mozilla/security/coreconf/OS2.mk,v  <--  OS2.mk
new revision: 1.24; previous revision: 1.23
done
Checking in command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.8; previous revision: 1.7
done
Checking in rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.66; previous revision: 1.65
done
Removing nsinstall/nfspwd;
/cvsroot/mozilla/security/coreconf/nsinstall/nfspwd,v  <--  nfspwd
new revision: delete; previous revision: 1.2
done
Removing nsinstall/nfspwd.pl;
/cvsroot/mozilla/security/coreconf/nsinstall/nfspwd.pl,v  <--  nfspwd.pl
new revision: delete; previous revision: 1.2
done

Comment 8

[Wan-Teh Chang]

*** Bug 88169 has been marked as a duplicate of this bug. ***