Closed Bug 311074 Opened 15 years ago Closed 15 years ago

NSS build fails when building from readonly sources

Categories

(NSS :: Build, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: wtc)

References

Details

Attachments

(2 files, 1 obsolete file)

When I'm building from readonly sources, the NSS build fails on the "clean"
target of coreconf/nsinstall because it tries to delete "nfspwd". I'm not really
sure why we have both "nfspwd" and "nfspwd.pl" in the tree, but the clean target
should definitely not be removing source files.
Attached patch Don't do the weird nfspwd thing (obsolete) — Splinter Review
Attachment #198459 - Flags: review?(wtchang)
Comment on attachment 198459 [details] [diff] [review]
Don't do the weird nfspwd thing

The definition of PLSRCS should also be removed.
Attachment #198459 - Flags: review?(wtchang) → review+
WTC, can you checkin the appropriate fix? I'm not sure what of trunk/branches
this belongs on (or even how the NSS branching system works).
This patch is what I checked in on the NSS trunk.
This change will eventually appear on the Mozilla
trunk (estimate: in a few weeks).

Checking in Makefile;
/cvsroot/mozilla/security/coreconf/nsinstall/Makefile,v  <--  Makefile
new revision: 1.10; previous revision: 1.9
done
Attachment #198459 - Attachment is obsolete: true
nfspwd.pl and nfspwd are Perl scripts that only worked
on the old Netscape intranet.  Since that network no
longer existed, these scripts are obsolete now and
should be cvs removed.	In makefiles nfspwd should be
replaced by the regular pwd command.
Attachment #198639 - Flags: review?(rrelyea)
Comment on attachment 198639 [details] [diff] [review]
cvs remove the obsolete nfspwd Perl script

r+ relyea
Attachment #198639 - Flags: review?(rrelyea) → review+
nfspwd and nfspwd.pl removed from CVS.

Checking in OS2.mk;
/cvsroot/mozilla/security/coreconf/OS2.mk,v  <--  OS2.mk
new revision: 1.24; previous revision: 1.23
done
Checking in command.mk;
/cvsroot/mozilla/security/coreconf/command.mk,v  <--  command.mk
new revision: 1.8; previous revision: 1.7
done
Checking in rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.66; previous revision: 1.65
done
Removing nsinstall/nfspwd;
/cvsroot/mozilla/security/coreconf/nsinstall/nfspwd,v  <--  nfspwd
new revision: delete; previous revision: 1.2
done
Removing nsinstall/nfspwd.pl;
/cvsroot/mozilla/security/coreconf/nsinstall/nfspwd.pl,v  <--  nfspwd.pl
new revision: delete; previous revision: 1.2
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.11
*** Bug 88169 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.