311079 - Add Italian locale to DOMI

Status: RESOLVED WONTFIX

(Mozilla Localizations :: it / Italian, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051004 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051004 SeaMonkey/1.1a

Zipped file coming with the Italian translation of DOMI, including
viewer-registry.dtd

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Italian translation

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 198462 [details]
Italian translation

not granting approval, we have issues with the download size, see bug 312510. Sorry.

Comment 3

[Michele Dal Corso]

Axel, why bug 312510 is marked as Resolved/fixed if it leaves out some localizations like Italian???

Comment 4

[Giacomo Magnini]

Attachment: Updated translation with changes from bug 109481

Comment 5

[Shawn Wilsher :sdwilsh]

I'm sorry - please update this and I can get it checked in for you.  Any future DOMi localizations should have me cc'd so I can get it in for you.

Comment 6

[Giuliano Masseroni [:jooliaan]]

Attachment: Updated it DOMI

Comment 7

[Giuliano Masseroni [:jooliaan]]

Attachment: Updated it DOMI

Comment 8

[Shawn Wilsher :sdwilsh]

Comment on attachment 272593 [details]
Updated it DOMI

Could you please attach a plain text diff generated with |cvs diff -u8pN|?  Thanks!

Comment 9

[Giacomo Magnini]

(In reply to comment #8)
> (From update of attachment 272593 [details])
> Could you please attach a plain text diff generated with |cvs diff -u8pN|? 
> Thanks!
> 

This is simply not possible, since we are adding a new dir and CVS doesn't permit this if you don't have write access. If we only added new files, it'd have been possible, or at least this is what http://developer.mozilla.org/en/docs/Creating_a_patch says.

Comment 10

[Shawn Wilsher :sdwilsh]

http://developer.mozilla.org/en/docs/Creating_a_patch#Including_new_files_in_a_patch

Comment 11

[Steffen Wilberg]

Shawn, that does not help here, since there's no "it" directory in mozilla/extensions/inspector/resources/locale/.

The doc you quoted says:
"Note that this trick does not work for new directories".

So create that "it" directory and copy the files and folders from inspector-IT.zip/inspector into it.

Comment 12

[Shawn Wilsher :sdwilsh]

That's interesting - the cvsutils that I got from here (http://www.red-bean.com/cvsutils/) seems to let me add directories without a problem.

Regardless, simply adding the locale files will not cause the DOMi to ship with that locale, so you'll still still need to provide a patch for the Makefile.

Comment 13

[Axel Hecht [:Pike]]

cvsdo add works with dirs, cvs diff doesn't. You can use cvsdo diff, though, as long as you don't try to diff existing files at the same time.

Comment 14

[Nickolay_Ponomarev]

> Any future DOMi localizations should have me cc'd so I can get it in for you.

Even better, use the checkin-needed keyword (if you have editbugs). See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

Comment 15

[Shawn Wilsher :sdwilsh]

(In reply to comment #13)
> cvsdo add works with dirs, cvs diff doesn't. You can use cvsdo diff, though, as
> long as you don't try to diff existing files at the same time.
cvs diff has worked for me as long as you manually specify each file.

Comment 16

[Giacomo Magnini]

It didn't for me after trying for half an hour.
Now I'm having trouble upgrading to F7, so it will take a bit longer still...

Comment 17

[Francesco Lodolo [:flod]]

Closing this bug, since a new bug (see bug 528548) has been filed to add Italian localization of Inspector to SeaMonkey.