311082 - regression in js1_5/Array/array-002.js

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

The following test regressed in the 10/4 branch and trunk builds on winxp.

Testcase js1_5/Array/array-002.js failed Bug Number 290592
[ Top of Page ]
STATUS: Array extras: forEach, indexOf, filter, map
Failure messages were:
FAILED!: Array.forEach: mutate
FAILED!: Expected value 'hello,mutated,undefined,', Actual value 'hello,mutated,'
FAILED!:
FAILED!: Array.forEach on sparse array
FAILED!: Expected value 'undefined,undefined,sparse,', Actual value 'sparse,'
FAILED!:
FAILED!: every element is a string
FAILED!: Expected value 'false', Actual value 'true'
FAILED!:
FAILED!: every element is a string, via object callback
FAILED!: Expected value 'false', Actual value 'true'
FAILED!:

Comment 1

[Brendan Eich [:brendan]]

This was all intention, AFAICT (some of these errors use the same string to
identify themselves, but don't all use sparse or dense arrays -- would by
helpful to have sparse or dense in the identifying string).  We used to fill
holes, we do not any longer.

Shaver, is this ok?  Cc'ing Igor and Norris too for second thoughts.

/be

Comment 2

[Igor Bukanov]

(In reply to comment #1)
> We used to fill holes, we do not any longer.

What was the reason to include holes when enumerating in the initial version of
extras? I was suprised as it not only deviated from other array methods but also
introduced inconsistency with for-in loop which skip holes. But then I do not
know the whole story.

Comment 3

[Scott MacGregor]

minusing this for right now based on Brendan's comments that this was
intentional. Feel free to renominate if you all discuss this further.

Comment 4

[Bob Clary [:bc] (inactive)]

Changes made to test and test moved to js1_6/Array...

Removing js1_5/Array/array-002.js;
/cvsroot/mozilla/js/tests/js1_5/Array/array-002.js,v  <--  array-002.js
new revision: delete; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_6/Array/regress-290592.js,v
done
Checking in js1_6/Array/regress-290592.js;
/cvsroot/mozilla/js/tests/js1_6/Array/regress-290592.js,v  <--  regress-290592.js
initial revision: 1.1
done