Closed Bug 311098 Opened 20 years ago Closed 19 years ago

Port changes made in bug 251625 to xpfe/ (remove .part files when cancelling downloads)

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ispiked, Assigned: ajschult784)

References

(
URL
)

Details

(Keywords: fixed-seamonkey1.1a)

Attachments

(1 file, 2 obsolete files)

what I checked in
3.66 KB, patch
csthomas
: approval-seamonkey1.1a+
Details | Diff | Splinter Review
This bug never got fixed for SeaMonkey.
*** Bug 310938 has been marked as a duplicate of this bug. ***
FF bug: Bug 251625 .part files not removed when cancelling or removing downloads
URL: show_bug.cgi?id=251625
OS: Windows XP → All
Hardware: PC → All
Flags: blocking-seamonkey1.1a?
biesi: Downloads are your area, would you be able to come up with a fix for the SeaMonkey side any time soon? Additionally, should we block 1.1 Alpha for that?
(No regression, no dataloss: no need to block for alpha !? My 2 cts.)
Attached patch port toolkit behavior (obsolete) — — Splinter Review
Assignee: download-manager → ajschult
Status: NEW → ASSIGNED
Attachment #232350 - Flags: review?(cbiesinger)
Comment on attachment 232350 [details] [diff] [review] port toolkit behavior GetTempFile() is never called !?
Comment on attachment 232350 [details] [diff] [review] port toolkit behavior And missing the .h file part too !?
Attached patch includes .h changes (obsolete) — — Splinter Review
Attachment #232350 - Attachment is obsolete: true
Attachment #232352 - Flags: review?(cbiesinger)
Attachment #232350 - Flags: review?(cbiesinger)
Comment on attachment 232352 [details] [diff] [review] includes .h changes Better, but still "GetTempFile() is never called !?"...
Comment on attachment 232352 [details] [diff] [review] includes .h changes r=biesi, although I see no point in GetTempFile and would remove it
Attachment #232352 - Flags: review?(cbiesinger) → review+
FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
comment nit: "there's other cancelallation causes" should be "there are other cancellation causes"
Flags: blocking-seamonkey1.1a? → blocking-seamonkey1.1a+
Attachment #232352 - Attachment is obsolete: true
Attachment #232380 - Flags: approval-seamonkey1.1a?
Attachment #232380 - Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Keywords: fixed-seamonkey1.1a
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: