When update URL is 404, engine update ignores updateCheckDays

RESOLVED FIXED

Status

SeaMonkey
Search
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: O. Atsushi (Torisugari), Assigned: O. Atsushi (Torisugari))

Tracking

({fixed1.8})

Trunk
fixed1.8
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Splitted from bug 306576.

Regardless of the HTTP status, we should record lastPingDate.
(Assignee)

Comment 1

12 years ago
Created attachment 198573 [details] [diff] [review]
Patch

Calling validateEngineNow() before HTTP status check.
Please take a look at bug 306576 comment26 as well.

This patch has tabs.
Attachment #198573 - Flags: review?(mconnor)
Comment on attachment 198573 [details] [diff] [review]
Patch

neil is probably a good SR for this:

regardless of the addons stuff, this is a win because we don't want to hit the
server more than once a day.
Attachment #198573 - Flags: review?(mconnor) → review+
(Assignee)

Updated

12 years ago
Attachment #198573 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

12 years ago
Assignee: search → torisugari
Status: ASSIGNED → NEW
(Assignee)

Updated

12 years ago
Flags: blocking1.8rc1?

Comment 3

12 years ago
this isn't a stop ship critical bug. Feel free to nominate the patch if it gets
sr for further discussion. 
Flags: blocking1.8rc1? → blocking1.8rc1-
This significantly impacts the amount of work that needs to be done on the
addons web tree for l10n, let's try to drive this in ASAP.
Blocks: 306576
Flags: blocking1.8rc1- → blocking1.8rc1?

Comment 5

12 years ago
Mike, we need more information than that. What's the change going to help,
what's the risk of taking it, and what kind of testing can we do to have some
confidence in this?

Updated

12 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+
Asa, this patch makes us consider a server error a response to keep the search
engine live. I consider a 404 a good sign of "no update", so does Mike et al.

This is a good move to control the server and admin load we put on hosts for 
search engine plugins in general, and in the case of bug 306576, addons.m.o.

Looking at the diff, I don't see a whole lot of risk, there is a whole bunch of 
error handling between the old place of validateEngineNow(theEngine) and the new
one, which handles invalid date formats and all that. All perfectly fine reasons
to not bother about updating the search engine plugin, IMHO.
Oops, we discussed this in a triage meeting, but didn't update the bug.  We're
just waiting on an SR now.

Comment 8

12 years ago
Comment on attachment 198573 [details] [diff] [review]
Patch

Sorry for not getting to this earlier, but myrealbox.com were upgrading when
you made the request so it got caught up in the backlog.
Attachment #198573 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Assignee)

Updated

12 years ago
Attachment #198573 - Flags: approval1.8rc1?

Updated

12 years ago
Attachment #198573 - Flags: approval1.8rc1? → approval1.8rc1+
Checked in branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → SeaMonkey

Updated

8 years ago
QA Contact: search
You need to log in before you can comment on or make changes to this bug.