Last Comment Bug 311195 - When update URL is 404, engine update ignores updateCheckDays
: When update URL is 404, engine update ignores updateCheckDays
Status: RESOLVED FIXED
: fixed1.8
Product: SeaMonkey
Classification: Client Software
Component: Search (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: O. Atsushi (Torisugari)
:
:
Mentors:
Depends on:
Blocks: 306576
  Show dependency treegraph
 
Reported: 2005-10-05 07:02 PDT by O. Atsushi (Torisugari)
Modified: 2011-08-05 21:15 PDT (History)
8 users (show)
asa: blocking1.8rc1+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.69 KB, patch)
2005-10-05 07:09 PDT, O. Atsushi (Torisugari)
mconnor: review+
neil: superreview+
asa: approval1.8rc1+
Details | Diff | Splinter Review

Description User image O. Atsushi (Torisugari) 2005-10-05 07:02:47 PDT
Splitted from bug 306576.

Regardless of the HTTP status, we should record lastPingDate.
Comment 1 User image O. Atsushi (Torisugari) 2005-10-05 07:09:40 PDT
Created attachment 198573 [details] [diff] [review]
Patch

Calling validateEngineNow() before HTTP status check.
Please take a look at bug 306576 comment26 as well.

This patch has tabs.
Comment 2 User image Mike Connor [:mconnor] 2005-10-05 08:07:57 PDT
Comment on attachment 198573 [details] [diff] [review]
Patch

neil is probably a good SR for this:

regardless of the addons stuff, this is a win because we don't want to hit the
server more than once a day.
Comment 3 User image Scott MacGregor 2005-10-10 16:36:17 PDT
this isn't a stop ship critical bug. Feel free to nominate the patch if it gets
sr for further discussion. 
Comment 4 User image Mike Connor [:mconnor] 2005-10-11 09:45:46 PDT
This significantly impacts the amount of work that needs to be done on the
addons web tree for l10n, let's try to drive this in ASAP.
Comment 5 User image Asa Dotzler [:asa] 2005-10-11 16:06:41 PDT
Mike, we need more information than that. What's the change going to help,
what's the risk of taking it, and what kind of testing can we do to have some
confidence in this?
Comment 6 User image Axel Hecht [:Pike] 2005-10-13 16:12:01 PDT
Asa, this patch makes us consider a server error a response to keep the search
engine live. I consider a 404 a good sign of "no update", so does Mike et al.

This is a good move to control the server and admin load we put on hosts for 
search engine plugins in general, and in the case of bug 306576, addons.m.o.

Looking at the diff, I don't see a whole lot of risk, there is a whole bunch of 
error handling between the old place of validateEngineNow(theEngine) and the new
one, which handles invalid date formats and all that. All perfectly fine reasons
to not bother about updating the search engine plugin, IMHO.
Comment 7 User image Mike Connor [:mconnor] 2005-10-13 18:15:09 PDT
Oops, we discussed this in a triage meeting, but didn't update the bug.  We're
just waiting on an SR now.
Comment 8 User image neil@parkwaycc.co.uk 2005-10-17 03:29:31 PDT
Comment on attachment 198573 [details] [diff] [review]
Patch

Sorry for not getting to this earlier, but myrealbox.com were upgrading when
you made the request so it got caught up in the backlog.
Comment 9 User image Mike Connor [:mconnor] 2005-10-17 11:10:23 PDT
Checked in branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.