311195 - When update URL is 404, engine update ignores updateCheckDays

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[O. Atsushi (Torisugari)]

Splitted from bug 306576.

Regardless of the HTTP status, we should record lastPingDate.

Comment 1

[O. Atsushi (Torisugari)]

Attachment: Patch

Calling validateEngineNow() before HTTP status check.
Please take a look at bug 306576 comment26 as well.

This patch has tabs.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 198573 [details] [diff] [review]
Patch

neil is probably a good SR for this:

regardless of the addons stuff, this is a win because we don't want to hit the
server more than once a day.

Comment 3

[Scott MacGregor]

this isn't a stop ship critical bug. Feel free to nominate the patch if it gets
sr for further discussion. 

Comment 4

[Mike Connor [:mconnor]]

This significantly impacts the amount of work that needs to be done on the
addons web tree for l10n, let's try to drive this in ASAP.

Comment 5

[Asa Dotzler [:asa]]

Mike, we need more information than that. What's the change going to help,
what's the risk of taking it, and what kind of testing can we do to have some
confidence in this?

Comment 6

[Axel Hecht [:Pike]]

Asa, this patch makes us consider a server error a response to keep the search
engine live. I consider a 404 a good sign of "no update", so does Mike et al.

This is a good move to control the server and admin load we put on hosts for 
search engine plugins in general, and in the case of bug 306576, addons.m.o.

Looking at the diff, I don't see a whole lot of risk, there is a whole bunch of 
error handling between the old place of validateEngineNow(theEngine) and the new
one, which handles invalid date formats and all that. All perfectly fine reasons
to not bother about updating the search engine plugin, IMHO.

Comment 7

[Mike Connor [:mconnor]]

Oops, we discussed this in a triage meeting, but didn't update the bug.  We're
just waiting on an SR now.

Comment 8

[[e-mail]]

Comment on attachment 198573 [details] [diff] [review]
Patch

Sorry for not getting to this earlier, but myrealbox.com were upgrading when
you made the request so it got caught up in the backlog.

Comment 9

[Mike Connor [:mconnor]]

Checked in branch and trunk.