311404 - Make nsHTMLContentSink easier to use

Status: RESOLVED WONTFIX

Description

[Blake Kaplan (:mrbkap) (leave, Aug. 16-Nov. 16)]

While working on bug 296963, I found that it was really hard to use
nsHTMLDocument and nsHTMLContentSink without doing lots of stuff unrelated to
parsing. I want to make these classes behave sanely if I don't have stuff like a
container (nsIDocShell) to pass.

Comment 1

[Blake Kaplan (:mrbkap) (leave, Aug. 16-Nov. 16)]

Created attachment 198738 [details] [diff] [review]
No containers required

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 198738 [details] [diff] [review]
No containers required

r+sr=jst

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

So... why is this defaulting to true?  Given that HTML loads subframes from
content, this will lead to random docshells that are not in a docshell tree
hanging about, and last I checked docshell did not quite deal well with that.

Comment 4

[Blake Kaplan (:mrbkap) (leave, Aug. 16-Nov. 16)]

I still need to work on that bit... Note that we never get here without a
docshell in the real world... only in my world, which cannot use
nsHTMLDocument::StartDocumentLoad for various reasons. I'm still trying to
figure out how the regression tests should handle <script> and <iframe> and friends.

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

> Note that we never get here without a docshell in the real world

Not even from accessibility?  I seem to recall aaron checked in some code that
parsed HTML to put nicer accessible text (based on title of document linked to,
eg) on links...

Comment 6

[Aaron Leventhal]

(In reply to comment #5)
> > Note that we never get here without a docshell in the real world
> 
> Not even from accessibility?  I seem to recall aaron checked in some code that
> parsed HTML to put nicer accessible text (based on title of document linked to,
> eg) on links...

I haven't checked that in yet. I'll update the trunk patch after the release of
1.5. It's bug 277469.

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Ah, that's using its own sink.  OK.

Comment 8

[Henri Sivonen (:hsivonen) (away until 2018-09-24)]

Moot now?

Comment 9

[Blake Kaplan (:mrbkap) (leave, Aug. 16-Nov. 16)]

Yes.