Closed
Bug 311404
Opened 20 years ago
Closed 15 years ago
Make nsHTMLContentSink easier to use
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mrbkap, Unassigned)
References
Details
Attachments
(1 file)
2.31 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
While working on bug 296963, I found that it was really hard to use
nsHTMLDocument and nsHTMLContentSink without doing lots of stuff unrelated to
parsing. I want to make these classes behave sanely if I don't have stuff like a
container (nsIDocShell) to pass.
Reporter | ||
Comment 1•20 years ago
|
||
Attachment #198738 -
Flags: superreview?(jst)
Attachment #198738 -
Flags: review?(jst)
Comment 2•20 years ago
|
||
Comment on attachment 198738 [details] [diff] [review]
No containers required
r+sr=jst
Attachment #198738 -
Flags: superreview?(jst)
Attachment #198738 -
Flags: superreview+
Attachment #198738 -
Flags: review?(jst)
Attachment #198738 -
Flags: review+
![]() |
||
Comment 3•20 years ago
|
||
So... why is this defaulting to true? Given that HTML loads subframes from
content, this will lead to random docshells that are not in a docshell tree
hanging about, and last I checked docshell did not quite deal well with that.
Reporter | ||
Comment 4•20 years ago
|
||
I still need to work on that bit... Note that we never get here without a
docshell in the real world... only in my world, which cannot use
nsHTMLDocument::StartDocumentLoad for various reasons. I'm still trying to
figure out how the regression tests should handle <script> and <iframe> and friends.
![]() |
||
Comment 5•20 years ago
|
||
> Note that we never get here without a docshell in the real world
Not even from accessibility? I seem to recall aaron checked in some code that
parsed HTML to put nicer accessible text (based on title of document linked to,
eg) on links...
Comment 6•20 years ago
|
||
(In reply to comment #5)
> > Note that we never get here without a docshell in the real world
>
> Not even from accessibility? I seem to recall aaron checked in some code that
> parsed HTML to put nicer accessible text (based on title of document linked to,
> eg) on links...
I haven't checked that in yet. I'll update the trunk patch after the release of
1.5. It's bug 277469.
![]() |
||
Comment 7•20 years ago
|
||
Ah, that's using its own sink. OK.
Reporter | ||
Updated•16 years ago
|
Assignee: mrbkap → nobody
Reporter | ||
Comment 9•15 years ago
|
||
Yes.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Whiteboard: [WONTFIX?]
You need to log in
before you can comment on or make changes to this bug.
Description
•