311442 - Location Bar history matching causes Camino to freeze.

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Graeme Porteous]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051006 Camino/1.0a1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051006 Camino/1.0a1+

From Console.app
-[NSBigMutableString getCharacters:range:] called with out-of-bounds range....

Reproducible: Always

Steps to Reproduce:
1. In the Location Bar type the beginning of an url
2. Press down to browse the url matches in your history
Actual Results:  
Camino spins with rainbow cursor.

Expected Results:  
Not freeze and autocomplete the url.

Comment 1

[Mike Pinkerton (not reading bugmail)]

hrm, i haven't seen this. did something here change recently?

Comment 2

[Simon Fraser [no longer active]]

I fumbled some string fu. Fix:

Index: src/browser/AutoCompleteTextField.mm
===================================================================
RCS file: /cvsroot/mozilla/camino/src/browser/AutoCompleteTextField.mm,v
retrieving revision 1.41
diff -u -r1.41 AutoCompleteTextField.mm
--- src/browser/AutoCompleteTextField.mm	5 Oct 2005 20:24:03 -0000	1.41
+++ src/browser/AutoCompleteTextField.mm	7 Oct 2005 01:24:02 -0000
@@ -750,7 +750,7 @@
   if (aLocation > curLength)    // sanity check or AppKit crashes
     return;
 
-  if ((aLocation + [aString length] == curLength) && [curValue compare:aString
options:0 range:NSMakeRange(aLocation, curLength)] == NSOrderedSame)
+  if ((aLocation + [aString length] == curLength) && [curValue compare:aString
options:0 range:NSMakeRange(aLocation, [aString length])] == NSOrderedSame)
     return;  // nothing to do
 

Comment 3

[Simon Fraser [no longer active]]

Fixed in both places.

Comment 4

[Wevah (Nate Weaver)]

*** Bug 311757 has been marked as a duplicate of this bug. ***

Comment 5

[Wevah (Nate Weaver)]

*** Bug 313966 has been marked as a duplicate of this bug. ***