311453 - Tooltips for bookmarks buttons should show title and URL

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Simon Fraser [no longer active]]

I often want to see the full title of stuff in my bookmarks toolbar, so I think
the tooltip should show the title and url.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Patch

The localizable.strings entry looks like:

"BookmarkButtonTooltipFormat" = "%1$@\n\n%2$@";  /* 1=title, 2=url */

yes, that works:
http://developer.apple.com/documentation/MacOSX/Conceptual/BPInternational/Articles/StringsFiles.html

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 198773 [details] [diff] [review]
Patch

looks ok, r=pink

Comment 3

[Simon Fraser [no longer active]]

Fixed in both places.

Comment 4

[Ulrik Sverdrup]

Two comments:
I. Could we consider reducing it from two newlines to one? I think that would
look better.
II. The bookmarks in the bookmarks manager also have tooltips, should or
shouldn't they look just the same?

Comment 5

[Simon Fraser [no longer active]]

(In reply to comment #4)
> Two comments:
> I. Could we consider reducing it from two newlines to one? I think that would
> look better.

Maybe "title (url)"? When I had "title<newline>url" it was hard to distinguish
one from the other.

> II. The bookmarks in the bookmarks manager also have tooltips, should or
> shouldn't they look just the same?

I think the buttons are different, in that the titles are more severely truncated.