Tooltips for bookmarks buttons should show title and URL

RESOLVED FIXED

Status

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Tracking

({fixed1.8})

Trunk
PowerPC
macOS
fixed1.8

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
I often want to see the full title of stuff in my bookmarks toolbar, so I think
the tooltip should show the title and url.
(Assignee)

Comment 1

14 years ago
Posted patch PatchSplinter Review
The localizable.strings entry looks like:

"BookmarkButtonTooltipFormat" = "%1$@\n\n%2$@";  /* 1=title, 2=url */

yes, that works:
http://developer.apple.com/documentation/MacOSX/Conceptual/BPInternational/Articles/StringsFiles.html
Attachment #198773 - Flags: review?(mikepinkerton)
Comment on attachment 198773 [details] [diff] [review]
Patch

looks ok, r=pink
Attachment #198773 - Flags: review?(mikepinkerton) → review+
(Assignee)

Comment 3

14 years ago
Fixed in both places.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 4

14 years ago
Two comments:
I. Could we consider reducing it from two newlines to one? I think that would
look better.
II. The bookmarks in the bookmarks manager also have tooltips, should or
shouldn't they look just the same?

(Assignee)

Comment 5

14 years ago
(In reply to comment #4)
> Two comments:
> I. Could we consider reducing it from two newlines to one? I think that would
> look better.

Maybe "title (url)"? When I had "title<newline>url" it was hard to distinguish
one from the other.

> II. The bookmarks in the bookmarks manager also have tooltips, should or
> shouldn't they look just the same?

I think the buttons are different, in that the titles are more severely truncated.
You need to log in before you can comment on or make changes to this bug.