Closed
Bug 311496
Opened 20 years ago
Closed 19 years ago
Safe Mode UI: "Make Changes and Restart" button should be disabled if no action is checked
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, polish)
Attachments
(1 file)
|
3.70 KB,
patch
|
mconnor
:
review+
asaf
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The "Make Changes and Restart" button in the safe mode window should be disabled
if no action is checked.
|
Assignee | |
Updated•20 years ago
|
OS: MacOS X → All
Hardware: Macintosh → All
|
||
Updated•19 years ago
|
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: blocking-firefox2+
Target Milestone: --- → Firefox 2 beta1
|
|
||
Updated•19 years ago
|
Priority: -- → P3
|
|
||
Updated•19 years ago
|
Whiteboard: .5d
|
|
Assignee | |
Updated•19 years ago
|
Assignee: mconnor → bugs.mano
Severity: minor → normal
Status: ASSIGNED → NEW
Priority: P3 → P2
|
|
Assignee | |
Comment 2•19 years ago
|
||
Attachment #223897 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: .5d → requires branch-landing of Bug 247849)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #223897 -
Attachment description: patch (requiers branch-landing of Bug 247849) → patch (requires branch-landing of Bug 247849)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #223897 -
Flags: approval-branch-1.8.1+
|
|
||
Comment 3•19 years ago
|
||
Comment on attachment 223897 [details] [diff] [review]
patch (requires branch-landing of Bug 247849)
you shouldn't be self-approving for branch, just request at the same time as the review :P
r+a=me
Attachment #223897 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
trunk:
Checking in browser/base/content/safeMode.js;
/cvsroot/mozilla/browser/base/content/safeMode.js,v <-- safeMode.js
new revision: 1.7; previous revision: 1.6
done
Checking in browser/base/content/safeMode.xul;
/cvsroot/mozilla/browser/base/content/safeMode.xul,v <-- safeMode.xul
new revision: 1.6; previous revision: 1.5
done
1.8 branch:
Checking in browser/base/content/safeMode.js;
/cvsroot/mozilla/browser/base/content/safeMode.js,v <-- safeMode.js
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in browser/base/content/safeMode.xul;
/cvsroot/mozilla/browser/base/content/safeMode.xul,v <-- safeMode.xul
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Keywords: fixed1.8.1
Whiteboard: requires branch-landing of Bug 247849)
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•