311607 - "Select new tabs opened from links" pref isn't obeyed for links dragged to existing tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[tyl2]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

There's an option to "Select new tabs opened from links." However, I want
basically the same feature if the destination tab is already open. In previous
versions of Firefox, I've been able to set the option to do so. v1.5 beta 1
seems to have taken that option away.

Reproducible: Always

Steps to Reproduce:
1. Load a webpage with selectable links, eg. my.yahoo.com (first tab).
2. Open new tab (second tab).
3. Select (go back to) the first tab.
4. Drag any link from first tab to second tab. Release mouse button.

Actual Results:  
Focus remains on first tab. Second tab, which is now loading a new page, remains
in the background.

Expected Results:  
(Given the appropriate customizable option), second tab should be brought to
focus/foreground when mouse button's released.

Again, I realize the developers may prefer the current behavior (though I'd be a
bit surprised). But at least give us the option so we don't have to click on the
tabs every time.

I'm filing this under minor bug rather than enhancement because it's a
previously available feature that's been lost, whether by chance or choice.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is a regression from the tab-drag&drop bug.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Revert to pre tab drag&drop behavior.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 198973 [details] [diff] [review]
patch

r=mano

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Trunk: mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.117;

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 198973 [details] [diff] [review]
patch

This is a very safe regression fix that just reverts to the 1.0.1 branch
behavior.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 198973 [details] [diff] [review]
patch

not serious enough to take the risk this late in the game.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 198973 [details] [diff] [review]
patch

this is very safe, and accidental breaking of UI functionality isn't
acceptable, period.

Comment 8

[tyl2]

I think this is more serious than breaking the "Select new tabs opened from
links" pref, which I think everyone would agree would be unacceptable. Besides,
it breaks expectations of how tabs work. So I really hope it's fixed by 1.5
rather than waiting till the indeterminate release of 1.6.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 198973 [details] [diff] [review]
patch

This just isn't something we'd stop ship for and it's not the default
configuration for what we ship. The negative side effect is minor.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> (From update of attachment 198973 [details] [diff] [review] [edit])
> This just isn't something we'd stop ship for and it's not the default
> configuration for what we ship. The negative side effect is minor. 

The patch is even more "minor". Not fixing a regression from the 1.0 behavior
due to someone accidentally removing code seems like the wrong decision to me,
but I suppose there are bigger things to worry about.

Comment 11

[Asaf Romano (gone)]

Scott, Asa, could you reconsider this patch for the branch? The patch is very
safe  and fixes an accidental UE-regression from the first beta. It's baking on
the trunk for about a week now.

Comment 12

[Asa Dotzler [:asa]]

Asaf, if you can get a verification on the trunk and some testing around tab
behaviors to make sure that nothing else regressed from this change, we'd
reconsider.

Comment 13

[Tracy Walker [:tracy]]

verified on Mac and Windows trunk builds from 1017 
I also did a little testing around the pref and things seem to be fine.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.103.2.12;

Thanks!