311717 - Firefox continues to use old Talkback version (Firefox10) even when upgraded to 1.5

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Reed Loden [:reed]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

Firefox crashed today, so Talkback started up... well, I noticed that Talkback
said "Firefox10" so I investigated some more. It seems that I now have two
copies of Talkback on my system: one in the components directory (Firefox10) and
one in the extensions directory (Firefox15).

Even though I am using Firefox 1.5 Beta 2, it used the old Firefox10 version of
Talkback instead the new one.

Reproducible: Didn't try

Steps to Reproduce:
1. Firefox crashed
2. Talkback started
3. Talkback was version Firefox10

Actual Results:  
Talkback was version "Firefox10"

Expected Results:  
The new talkback version (Firefox15) should have been used for the bug report
and not the old version.

When I upgraded to Firefox 1.5 (beta 1/2), it should have removed the old
Talkback version and made the new one kick into effect.

Also, would it be possible for Talkback to transfer your settings from the
Firefox10 version to the Firefox15 version?

Comment 1

[Adam Guthrie]

How did you upgrade to 1.5, and how did you install Talkback in 1.0?

Comment 2

[Reed Loden [:reed]]

(In reply to comment #1)
> How did you upgrade to 1.5, and how did you install Talkback in 1.0?

I installed both 1.5 beta 1 and beta 2 (when they came out) from the win32
executable.

Talkback was installed via the "Advanced Options (?not sure on name?)" when
installing Firefox. I selected it along with DOM Inspector, etc.

Comment 3

[Jay Patel [:jay]]

I don't believe there is a way to transer settings for the old Talkback
installation (in components), to the new location (in extensions).  However, it
does seem as if installing a new build over a 1.0.x app directory does not do
enough cleanup in order for the new Talkback to work as expected.

I will do some more investigating and hopefully this is as simple as removing
the old Talkback files from the components directory during an install of a
newer version that uses the new extensions directory location.

Comment 4

[Reed Loden [:reed]]

Since this has now been confirmed, requesting blocking1.8rc1.

Comment 5

[Chase Phillips]

In 1.0, Talkback was in the components/ directory.  In 1.5, Talkback moved into
the extensions/ subdirectory.  Installing 1.5 over 1.0 will lead to two Talkback
installations, one in components/ and one in extensions/.  Probably the updated
1.5 installation is using the 1.0 Talkback.

If this is the problem, the fix is to add the 1.0 Talkback files to the list of
removed files that the installer and updater remove when they run.  That change
should be made on the 1.8 branch and trunk.

Comment 6

[Chase Phillips]

(In reply to comment #5)
> If this is the problem, the fix is to add the 1.0 Talkback files to the list of
> removed files that the installer and updater remove when they run.  That change
> should be made on the 1.8 branch and trunk.

And for both Firefox and Thunderbird, since this problem most likely affects it,
too.

Comment 7

[Jay Patel [:jay]]

Taking bug, I'll find the right places to remove the old Talkback files.

Comment 8

[Jay Patel [:jay]]

Attachment: Patch to remove Talkback files from old install location

This patch should cleanup stuff for Windows, but not sure what we need to do
for the Linux.	If this works for the Trunk, we should get this in for 1.5 RC1.


Since the Linux installer doesn't use the removed-files.in file, we might need
to find another way to clean out those files (if we care enough about 1.0.x
Linux users that will be updating to 1.5.x).  

According to bsmedberg and chase, the new update system uses the
removed-files.in file, so future updaters will be fine for 1.5.x onwards on all
platforms.

Comment 9

[Chase Phillips]

Comment on attachment 199108 [details] [diff] [review]
Patch to remove Talkback files from old install location

This misses some Talkback files on Unix.  See
http://lxr.mozilla.org/aviary101branch/source/browser/installer/unix/packages-s
tatic#298.

Comment 10

[Jay Patel [:jay]]

Attachment: New patch that includes removal of unix specific Talkback files

Comment 11

[Jay Patel [:jay]]

Just tried to reproduce this on Linux and discovered that this should not be a
problem for Linux users that use the installer...since you can only either
install to a new location or have an existing directory completely deleted. 
Still a problem if you simply untar the newer builds on top of an existing
install though.

Comment 12

[Scott MacGregor]

Comment on attachment 199111 [details] [diff] [review]
New patch that includes removal of unix specific Talkback files

you'll need to change mozilla\mail\installer\removed-files.in as well.

Comment 13

[Jay Patel [:jay]]

Checked in on Trunk.  Will verify changes with tomorrow's Trunk build and then
pull the branch for checkin there after some testing.

Comment 14

[Scott MacGregor]

Jay, please see comment 12. Would like to see that addressed in the patch before
granting rc1 approval. Thanks!

Comment 15

[Jay Patel [:jay]]

Scott:  Yeah, sorry, I patched up the mail file as well for the Trunk (although
it wasn't in the attached patch).  Will be sure to include both file changes in
the branch patch I submit tomorrow for rc1 approval.

Comment 16

[Jay Patel [:jay]]

I was able to verify that the old files are now being removed when I install
over a 1.0.x build with today's Trunk, but have not been able to see if Talkback
is actually working. :-)

I'm having trouble reproducing crashes with today's Trunk build...so if people
can help test this, that will be great.   Here are the steps:

On Windows:
1. Install Firefox 1.0.7 and make sure Talkback is enabled
2. Check to see if the Talkback files are in the components directory
2. Crash the browser and submit a Talkback report with something in the comment
that mentions this bug and that you crashed with 1.0.7.
3. Install today's 10/11 Trunk build over the install directory of 1.0.7.
4. Check to see if the Talkback files in the patch have been removed from the
/components directory and that the proper files are now in the
/extensions/[e-mail]/components directory.
5. Crash the browser and submit the Talkback report with something in the
comment that mentions this bug and that you crashed with today's Trunk build.

Then post the Talkback IDs for both crashes you submitted in this bug...or look
them up yourself at http://talkback-public.mozilla.org/talkback/fastfind.jsp and
see if the correct Talkback info is being collected for each of the crashes.

Comment 17

[Jay Patel [:jay]]

Ok, wasn't sure what URL caused the crash, but I was able to crash with my Trunk
build (installed on top of 1.0.7) and things look good on Windows:
Incident ID: 10516107
Stack Signature	jpinscp.dll + 0xaa87 (0x6d42aa87) 4b2b8dba
Email Address	[e-mail]
Product ID	FirefoxTrunk
Build ID	2005101106
Trigger Time	2005-10-11 12:04:28.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	jpinscp.dll + (0000aa87)
URL visited	testing bug 311717
User Comments	this should be an incident showing 20051011 as the build id and
TalkbackTrunk as the product.
Since Last Crash	1712 sec
Total Uptime	1712 sec
Trigger Reason	Stack overflow
Source File, Line No.	N/A

Comment 18

[Jay Patel [:jay]]

I did some more testing on Linux and things look okay for the following scenerios:

1. Install 1.0.7 with installer, Install Trunk with installer:  Not a problem
since you cannot install over an existing directory without deleting the entire
directory.

2. Untar or Install 1.0.7 with installer, Untar Trunk: Although both versions of
Talkback remain in the install directory, crashes with the Trunk build show up
correctly with the new Talkback info.

And on Windows, as my previous comment mentions, the old Talkback files are
removed during the install of the Trunk build over 1.0.7.

I have not had a chance to test Software Update on Linux or Windows since Trunk
builds on Linux are busted (can't access Help menu), and Software Update doesn't
seem to be working for me if I install the 10/10 Trunk build over 1.0.7 and then
try to update to 10/11 Trunk (seems to work on a clean 10/10 install and update
to 10/11, so there might be some other problem with Software Update when you
install the latest nightlies over 1.0.x builds).

I will test again tomorrow before marking this verified and submitting a branch
patch for review and approval.

Comment 19

[Jay Patel [:jay]]

v.fixed on Trunk for Firefox and Thunderbird.  Installer nightly builds remove
old Talkback files when installed over a 1.0.x instance.  This should clean up
things for users that upgrade using the installer to the latest Trunk and 1.5.x
builds in the same location as their 1.0.x installs.

Although this should also work with Software Update...there is a bug, most
likely in software update, that does not allow me to properly update for the
following case:

1. Install 1.0.7
2. Install 10/10 Trunk build
3. Software Update to 10/11 build

Both the partial and full updates fail to apply when trying to update to the
first build that has these changes.  Other updates work (10/8->10/9->10/10 and
10/11->10/12), just not that one day jump that should apply the removed-files.in
change.  We need to look into Software Update to see why it's failing.

Comment 20

[Jay Patel [:jay]]

Attachment: Branch patch to removed old Talkback files for both mail and browser

Just need a review from Chase and approval for 1.8 branch checkin so we can get
this in for 1.5 RC1.

Comment 21

[Jay Patel [:jay]]

Checked in on 1.8 branch.  Will verify with tomorrow's builds.

Comment 22

[Jay Patel [:jay]]

v.fixed on branch with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5)
Gecko/20051013 Firefox/1.4.1.  Both installing over 1.0.7 and various Software
Update scenerios work as expected.

If others can test installing 10/12 branch builds over 1.0.7 and then updating
to today's 10/13 build, that will be great.  Make sure the old files are removed
and then submit a crash with Talkback and verify that the info in the report is
accurate.  Thanks.

Comment 23

[Marc Bejarano]

*** Bug 308419 has been marked as a duplicate of this bug. ***