The default bug view has changed. See this FAQ.

bfcache doesn't stop plugins correctly

RESOLVED FIXED

Status

()

Core
Document Navigation
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({fixed1.8})

Trunk
fixed1.8
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is an unfortunate consequence of nsPluginHostImpl registering itself with
two different CIDs.  As a result, you get two instances of it floating around.
nsObjectFrame stops the plugin on the instance that's gotten via the plugin
manager CID and contract, while presshell (for bfcache) uses the plugin host
contract, which means the plugins are not fully stopped...
The upshot is that we stop the plugin itself, but the plugin manager still
thinks the plugin is running, which breaks things like trying to unload the
plugin if plugin reload happens.
Created attachment 200416 [details] [diff] [review]
Fix

Brian, if you can't get to this in time for it to make 1.8, please let me know
ASAP so I can ask someone else for review Sunday morning.  If you do get to
this tomorrow, could you go ahead and check it in?
Attachment #200416 - Flags: superreview?(bryner)
Attachment #200416 - Flags: review?(bryner)
I think this is something we should really fix on branch -- we don't want to be
creating a second instance of the plugin host (which is effectively what this
codepath does), since that makes it very unclear which one of them is actually
responsible for the running plugins.  This fix is very very safe, and I'm hoping
I'll get review by Sunday... :(
Flags: blocking1.8rc1?
Attachment #200416 - Flags: superreview?(bryner)
Attachment #200416 - Flags: superreview+
Attachment #200416 - Flags: review?(bryner)
Attachment #200416 - Flags: review+
checked in on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Attachment #200416 - Flags: approval1.8rc1?

Updated

12 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+

Updated

12 years ago
Attachment #200416 - Flags: approval1.8rc1? → approval1.8rc1+
checked in on branch.
Keywords: fixed1.8
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: bryner → bzbarsky
Status: REOPENED → NEW
Status: NEW → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
Depends on: 313669

Updated

9 years ago
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.