311822 - No whitespace between inline elements in <caption> tags (a, em, b, i) (link)

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P1)

Description

[Will]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

It seems that for any two links (<a> tags) separated by a space, contained in
the <caption> tag of a table, the space is not rendered. See the specified URL.
The words 'hello' and 'there' are two different links with a space between them.

Reproducible: Always

Steps to Reproduce:
1. Navigate to http://smurl.us/6
Actual Results:  
The caption reads 'hellothere'

Expected Results:  
The caption should read 'hello there'

Comment 1

[dolphinling]

Weird.

[e-mail]: I assume setting this to 1.0 branch was a mistake? 

Confirmed

Comment 2

[dolphinling]

Attachment: testcase

It's not just for <a>, it's for any two inline elements with only whitespace
between them.

Occurs in quirks and strict. 

I'm going to change the summary, and I'm also going to move this to Layout:
Tables, since I think we handle captions differently than normal block and
inline elements.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> I assume setting this to 1.0 branch was a mistake?

Yeah, it's my mistake, thanks.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I don't see what in the TableProcessChildren codepath causes
whitespace-stripping, but I also don't see any reason we should be going
through TableProcessChildren to construct the children of a block.

Comment 5

[Bernd]

Comment on attachment 199513 [details] [diff] [review]
patch

This should be indeed identical to the situation at the table cell

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.

Comment 7

[arno renevier]

Attachment: reftest

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 259040 [details] [diff] [review]
reftest

I don't think we need tests for each inline element -- certainly not in separate files.  I'm also a little hesitant to include a since some users have the pref set to always underline links.

So how about dropping the a test and combining the others into just three files (-1, -2, -ref) by just putting the tests above/below each other in the same file?

The basic idea of the tests looks fine, though.

Comment 9

[arno renevier]

thanks for your comments. I'll attach a revised reftest.

Comment 10

[arno renevier]

Attachment: reftest-2

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 259080 [details] [diff] [review]
reftest-2

I committed these reftests to the trunk with the following changes:

 * I made the captions with <em> and <i> elements inside them font-style: italic in case the spaces were different width between italic and non-italic fonts (a problem you already fixed for bold and non-bold)

 * I cleaned up the formatting of the head elements and added a title to the tests

 * I renamed the tests, since the tests and the references were swapped -- the one that showed the bug was the one you had marked "-ref", and it should be the other way around.

So r=dbaron with those changes -- and I just checked it in.  Thanks for making the test, and sorry I took so long to get to it.