311830 - [FIX]Random window-related cleanups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See review comments in bug 296639 comment 49.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Most of this is straightforward cleanup.  The one interesting bit (which needs
bryner's review, or someone else familiar with focus) is the change to
nsEventStateManager::PreHandleEvent in the NS_LOSTFOCUS case (the part that
says "@@ -711,32 +689,18 @@ nsEventStateManager::PreHandleEvent(nsPr").  The
change here was that I realized that ourGlobal is unused, and has been ever
since saari checked this code in.  He copy/pasted the code from somewhere that
_did_ use ourGlobal to get a focus controller to suppress; that was the
NS_DEACTIVATE case at the time, and that code has since been removed
(NS_DEACTIVATE now just gets the focus controller from mDocument).

I believe the change I made completely preserves the existing behavior, but I'm
not sure whether that was correct to start with, so would like some advice on
that.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 199038 [details] [diff] [review]
Patch

sr=jst on these changes. I honestly don't understand focus well enough to answer your focus question...

Comment 3

[Boris Zbarsky [:bzbarsky]]

jst, all good.  That's where bryner's review comes in.  ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to tip

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.