311838 - Bookmark folder keywords not saved when bookmark info panel is closed

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Joshua Bereiter]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051007 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20051007 Camino/1.0+

When assigning a keyword to a bookmark folder, it will not be saved unless the
system caret is placed outside the keyword textbox. Closing the panel with
escape or clicking the close button results in loss of edits to the keyword
field. This does not happen for regular bookmarks.

Reproducible: Always

Steps to Reproduce:
1. Get Info on a bookmark folder
2. Fill out a keyword
3. Hit escape or click the info panel's close box.

Actual Results:  
Keyword is not stored.

Expected Results:  
Keyword should be stored.

Comment 1

[Chris Lawson (gone)]

Further clarification: this only happens if the folder is NOT a tab group. If
the folder is a tab group, there's no problem.

I can reproduce with an official nightly. Confirming.

cl

Comment 2

[Mike Pinkerton (not reading bugmail)]

what does it mean for a folder that's not a tabgroup to have a keyword?

Comment 3

[Chris Lawson (gone)]

(In reply to comment #2)
> what does it mean for a folder that's not a tabgroup to have a keyword?

Hrm. I dunno. Probably nothing, since there isn't a specific behaviour the
folder should follow when the keyword is "activated."

Maybe we should disable the keyword field for bookmark folders that aren't tab
groups?

cl

Comment 4

[Joshua Bereiter]

(In reply to comment #2)
> what does it mean for a folder that's not a tabgroup to have a keyword?

Entering the keyword opens all the folder's items in tabs. This is especially
useful with replacement keywords, where %s is passed to every bookmark in the
folder.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this just a nib change or is code needed (I think Jasper is going to be working on this nib for some other bugs for 1.0)?

Comment 6

[Simon Fraser [no longer active]]

Code is needed.

Comment 7

[Simon Fraser [no longer active]]

Fixed now.