IMAP capability flags remembered across capability responses

RESOLVED FIXED

Status

MailNews Core
Networking: IMAP
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: Scott Talbot, Assigned: Bienvenu)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
x86
All
fixed1.8.0.4, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051011 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051011 SeaMonkey/1.1a

An IMAP server that I (would like to) connect to requires STARTTLS before login
so advertises logindisabled on connect (CAPABILITY IMAP4REV1 <stuff> STARTTLS
LOGINDISABLED), but after STARTTLS it doesn't advertise logindisabled and gives
some login types (CAPABILITY IMAP4REV1 <morestuff> AUTH=PLAIN AUTH=LOGIN).
Mozilla remembers the logindisabled so fails auth thinking that it's denied.

Reproducible: Always

Steps to Reproduce:
1. Connect to IMAP server that requires starttls.

Actual Results:  
Login failed.

Expected Results:  
Logged in.
(Reporter)

Comment 1

12 years ago
Created attachment 199140 [details] [diff] [review]
Forget capability flags.

capability_data() is called on every CAPABILITY response to parse flags out of
the capability so forget flags we know about and start afresh.
(Assignee)

Comment 2

12 years ago
Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

thx, I thought I'd fixed this, but apparently not.
Attachment #199140 - Flags: superreview+
Attachment #199140 - Flags: review+
(Reporter)

Comment 3

12 years ago
I'm not a committer, could someone check this in for me?
(Assignee)

Comment 4

12 years ago
fixed on trunk, thx.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

12 years ago
*** Bug 317540 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 6

11 years ago
Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

we want this for the branch
Attachment #199140 - Flags: branch-1.8.1+
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
OS: Windows XP → All
Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

hmm, please consider to add this fix to 1.8.0 branch.
It bakes long enough on 1.8 and trunk, is simple and is kind of security related since it blocks using some secure methods of authentication.
Attachment #199140 - Flags: approval1.8.0.3?
Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #199140 - Flags: approval1.8.0.4? → approval1.8.0.4+
checked in for 1.8.0 branch
Keywords: fixed1.8.0.4
(Assignee)

Comment 10

11 years ago
*** Bug 324138 has been marked as a duplicate of this bug. ***
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.