312244 - +[NSURL urlFromWebloc:] uses an FSSpec when it doesn't need to.

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Wevah (Nate Weaver)]

No need for FSSpec when it can just be done with the FSRef we already have.
Patch right-quick.

Comment 1

[Wevah (Nate Weaver)]

Attachment: Patch!

Comment 2

[Simon Fraser [no longer active]]

Comment on attachment 199362 [details] [diff] [review]
Patch!

>   
>-  if (inFile && !FSPathMakeRef((UInt8 *)[inFile fileSystemRepresentation], &ref, NULL) && !FSGetCatalogInfo(&ref, kFSCatInfoNone, NULL, NULL, &spec, NULL)) {
>+  if (inFile && !FSPathMakeRef((UInt8 *)[inFile fileSystemRepresentation], &ref, NULL)) {
>     short resRef;

Change to (FSPathMakeRef(...) == noErr) and r=me.

Comment 3

[Wevah (Nate Weaver)]

Attachment: Patch mk2.

This patch uses an explicit comparison to noErr.

Comment 4

[Mark Mentovai]

b&t