312260 - Bogus "undefined property" strict warning in switch discriminants

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Testcase:
switch ({}.foo) {}

Result:
Warning: reference to undefined property {}.foo

<brendan> in a switch discriminant, that should be a Detecting case
<brendan> so this strict warning is bogus, a bug

Comment 1

[Brendan Eich [:brendan]]

Anyone want to take this?  It should be easy.

/be

Comment 2

[Jeff Walden [:Waldo]]

Attachment: This easy?

This was tested against both the given testcase and against a testcase with
2000 case statements which should require one of the extended switch bytecodes.
 I haven't looked at this code (or much of the rest of js, for that matter) *at
all* before this, however, so I might be missing something obvious to anyone
more familiar with the code.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 199610 [details] [diff] [review]
This easy?

Yes, that easy.  Thanks, please feel free to check in if you have CVS access
(if you don't have CVS access, but want access, file a bug in the mozilla.org
product, CVS access component, and reference your patch-work).

/be

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk.
mozilla/js/src/jsopcode.tbl; new revision: 3.45;

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in regress-312260.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-312260.js,v  <--  regress-312260.js
initial revision: 1.1
done

Comment 6

[Brendan Eich [:brendan]]

Looks like I fixed this on the branch in a patch for another bug.  No harm.

/be

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.x and trunk.