Closed Bug 312364 Opened 19 years ago Closed 19 years ago

Arrow key events to plugin also cause page scrolling

Categories

(Camino Graveyard :: Plug-ins, defect)

Product:
Camino Graveyard
Component:
Plug-ins
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.0

People

(Reporter: sfraser_bugs, Assigned: mark)

References

(
URL
)

Details

(Keywords: fixed1.8)

Attachments

(1 file, 2 obsolete files)

Bestest fix
2.87 KB, patch
sfraser_bugs
: review+
Details | Diff | Splinter Review 
Try the sample URL (Flash). Even though the Flash plugin is handling the arrow
keys, we're still scrolling the page. This has to suck for Flash games.
Attached patch Fix (obsolete) — — Splinter Review 
The EventRecord was wrong down in nsPluginInstanceOwner::KeyPress, but only for
the initial keyDown, not for subsequent repeat autoKey "presses."  The event
conversion and dispatch in koko-widget was only creating an EventRecord when
the event was a repeat key.  When it wasn't, nativeMsg was an NSEvent, which
was wrong.

Simon also noticed that the EventRecord went out of scope even when the
keypress was a repeat, although that wasn't affecting anything directly.
Assignee: sfraser_bugs → mark
Status: NEW → ASSIGNED
Attachment #199482 - Flags: superreview?(sfraser_bugs)
Attachment #199482 - Flags: review?(sfraser_bugs)
Attached patch Better fix (obsolete) — — Splinter Review 
Put everything into one big happy conditional.
Attachment #199482 - Attachment is obsolete: true
Attachment #199485 - Flags: superreview?(sfraser_bugs)
Attachment #199485 - Flags: review?(sfraser_bugs)
Attachment #199482 - Flags: superreview?(sfraser_bugs)
Attachment #199482 - Flags: review?(sfraser_bugs)
Attachment #199485 - Flags: superreview?(sfraser_bugs)
Attachment #199485 - Flags: superreview+
Attachment #199485 - Flags: review?(sfraser_bugs)
Attachment #199485 - Flags: review+
Pls check into trunk and branch (be sure to make it plain that your branch
checkin is Camino-only in the comment).
Flags: camino1.0+
Target Milestone: --- → Camino1.0
Attached patch Bestest fix — — Splinter Review 
Also sets nativeMsg on all NS_KEY_PRESS events fired by -insertText:, for
compatibility with Carbon widgets.
Attachment #199485 - Attachment is obsolete: true
Attachment #199516 - Flags: review?(sfraser_bugs)
Attachment #199516 - Flags: review?(sfraser_bugs) → review+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: