Closed
Bug 312364
Opened 20 years ago
Closed 20 years ago
Arrow key events to plugin also cause page scrolling
Categories
(Camino Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.0
People
(Reporter: sfraser_bugs, Assigned: mark)
References
()
Details
(Keywords: fixed1.8)
Attachments
(1 file, 2 obsolete files)
|
2.87 KB,
patch
|
sfraser_bugs
:
review+
|
Details | Diff | Splinter Review |
Try the sample URL (Flash). Even though the Flash plugin is handling the arrow
keys, we're still scrolling the page. This has to suck for Flash games.
|
Assignee | |
Comment 1•20 years ago
|
||
The EventRecord was wrong down in nsPluginInstanceOwner::KeyPress, but only for
the initial keyDown, not for subsequent repeat autoKey "presses." The event
conversion and dispatch in koko-widget was only creating an EventRecord when
the event was a repeat key. When it wasn't, nativeMsg was an NSEvent, which
was wrong.
Simon also noticed that the EventRecord went out of scope even when the
keypress was a repeat, although that wasn't affecting anything directly.
Assignee: sfraser_bugs → mark
Status: NEW → ASSIGNED
Attachment #199482 -
Flags: superreview?(sfraser_bugs)
Attachment #199482 -
Flags: review?(sfraser_bugs)
|
|
Assignee | |
Comment 2•20 years ago
|
||
Put everything into one big happy conditional.
Attachment #199482 -
Attachment is obsolete: true
Attachment #199485 -
Flags: superreview?(sfraser_bugs)
Attachment #199485 -
Flags: review?(sfraser_bugs)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #199482 -
Flags: superreview?(sfraser_bugs)
Attachment #199482 -
Flags: review?(sfraser_bugs)
|
Reporter | |
Updated•20 years ago
|
Attachment #199485 -
Flags: superreview?(sfraser_bugs)
Attachment #199485 -
Flags: superreview+
Attachment #199485 -
Flags: review?(sfraser_bugs)
Attachment #199485 -
Flags: review+
|
|
Reporter | |
Comment 3•20 years ago
|
||
Pls check into trunk and branch (be sure to make it plain that your branch
checkin is Camino-only in the comment).
Flags: camino1.0+
Target Milestone: --- → Camino1.0
|
|
Assignee | |
Comment 4•20 years ago
|
||
Also sets nativeMsg on all NS_KEY_PRESS events fired by -insertText:, for
compatibility with Carbon widgets.
Attachment #199485 -
Attachment is obsolete: true
Attachment #199516 -
Flags: review?(sfraser_bugs)
|
|
Reporter | |
Updated•20 years ago
|
Attachment #199516 -
Flags: review?(sfraser_bugs) → review+
|
|
Assignee | |
Updated•20 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•