31241 - backend URI cleanup - switch to using native mail objects instead of passing around URI strings

Status: RESOLVED WONTFIX

(MailNews Core :: Backend, defect, P2)

Description

[Alec Flett]

This is the master bug for the URI cleanup I'm doing for mail.

I'll mostly use this bug to attach patches/etc so I can test my stuff on
multiple machines and platforms.

Comment 1

[Alec Flett]

oops meant to reassign to me.

Comment 2

[Alec Flett]

Attachment: fix up Get/Set folder and msgkey

Comment 3

[Alec Flett]

Attachment: ignore the last one, forgot the idl

Comment 4

[Alec Flett]

reassign to sspitzer - this is the bit about switching over to using native mail
objects instead of passing around URI strings. come see me if you want to know
what this is about... this can be done in many stages.
my patches above are checked in, I believe

Comment 5

[Bradley Baetz (:bbaetz)]

Seth told me to file a bug on mailnews uri cleanup when I was talking to him the
other day.

I guess this bug will do instead :)

You need to make sure that all protocols you have which ever get to necko in any
way are registered with a necko protocol handler, too.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This is blocking mime service work... we need to be able to Clone() uris and
mailnews ones are not Clone()-able.  (see bug 78943, comment #35).  I'm not sure
we ever really deal with mailnews uris in that code, but I'd rather not break,
say, attachment handling by accident.  :)

Comment 7

[James Salsman]

Is this ready for review?

Comment 8

[James Salsman]

Last comment bugmail "Excluding: [e-mail],..."

Therefore, setting this to 1.6a in hopes that it gets reviewed before 1.7 work.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Those diffs are against files that don't seem to even exist anymore (got
renamed? removed?)

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

date: 2001/03/17 02:54:07;  author: sspitzer%netscape.com;  state: dead;  lines:
+0 -0
remove files no longer part of the build due to the mailnews landing.
(specifically, there is no more message datasource or nsIMessage)


This is the last log message for all three patched files.
Therefore, marking INVALID.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Uh-huh.  Except those patches were just the _first_ patches for this bug.  See
comment 0 or something.  Mailnews URI implementations still need to be fixed, as
we move to separate apps, if only because once mailnews is a separate app, necko
and core layout components should NOT be working around bugs in it any more (and
I will probably start removing such workarounds if I modify the relevant code).
 So we really do want to fix this.

Comment 12

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 13

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 14

[Wayne Mery (:wsmwk)]

Does this (and the patches) have any value eighteen years later with today's code.

Comment 15

[:aceman]

The attached patches do not really do much.
But I'd forward to Jorg who is familiar with our mailnews URIs.

Comment 16

[Jorg K (CEST = GMT+2)]

I don't understand what the aim is here. Something like this

-NS_IMETHODIMP nsMessage::GetMime2DecodedSubject(nsString *resultSubject)
+NS_IMETHODIMP nsMessage::GetMime2DecodedSubject(PRUnichar* *resultSubject)

is certainly an r- since there's no way we're going from a smart string to a raw string.

Let's close this.