312437 - Do not display the "Impersonate this user" link when the user is in the bz_sudo_protect group

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

We actually need several steps before getting an error message telling us that
the user we try to impersonate is in the bz_sudo_protect group.
admin/users/userdata.html.tmpl, line 34 should take care of that:

        <a href="relogin.cgi?action=sudo&target_login=
        [%- otheruser.login FILTER html %]">Impersonate this user</a>

It should be displayed only when [% otheruser.groups.bz_sudo_protect %] is
false. Note that 'usevisibilitygroups' doesn't need to be checked here as only
users with editusers privs can see this link; and these users can bypass this
visibility restriction anyway.

Comment 1

[A. Karl Kornel]

Attachment: Patch v1

A relatively simple change.  Since the template gets an object corresponding to
the user who we wish to edit, it's easy enough to see if the user is in the
bz_sudo_protect group, and then only display the link if they are not.

Requesting review from jouni.

Comment 2

[Frédéric Buclin]

Comment on attachment 199565 [details] [diff] [review]
Patch v1

>+        [% IF !otheruser.in_group("bz_sudo_protect") %]

For consistency among templates, could we use otheruser.groups.bz_sudo_protect?
.in_group() is used nowhere else in templates.

Comment 3

[A. Karl Kornel]

Attachment: Patch v1.1

Modification of attachment 199565 [details] [diff] [review] with respect to comment 2:

> For consistency among templates, could we use
otheruser.groups.bz_sudo_protect?
> .in_group() is used nowhere else in templates.

OK.

Comment 4

[Jouni Heikniemi]

Comment on attachment 199631 [details] [diff] [review]
Patch v1.1

>+          <a href="relogin.cgi?action=sudo&target_login=
>+          [%- otheruser.login FILTER html %]">Impersonate this user</a>
>+        [% END %]

r=jouni, but turn the & into an &amp; prior to checkin (yes I know you didn't
cause it).

Comment 5

[Frédéric Buclin]

Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v
 <--  userdata.html.tmpl
new revision: 1.3; previous revision: 1.2
done