Closed Bug 312572 Opened 15 years ago Closed 15 years ago

Simplify syntax error handling/logging in IMAP parsing

Categories

(MailNews Core :: Networking: IMAP, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: engel, Assigned: engel)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

The following simplifications can implemented easily and without
changing any behavior of the IMAP implementation.

* remove field |nsIMAPGenericParser::fSyntaxErrorLine|
* remove method |nsIMAPGenericParser::::CreateSyntaxErrorLine()|
Status: NEW → ASSIGNED
Comment on attachment 199684 [details] [diff] [review]
Simplify syntax error handling/logging in IMAP parsing

looks good - I'll try running with this, though I don't often have contact with
servers that cause syntax errors :-)
Attachment #199684 - Flags: review?(bienvenu) → review+
fixed, thx, Hans. Sorry, I forgot to credit you in my checkin comment :-(
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Regarding the incomplete checkin comment: No Problem!  (Anyway, it was a trivial
patch, only leading to a small improvement of the code.)

David, thank you for the timely processing of this bug!
Blocks: 313038
I'm doing an LXR verification of this, because to be honest I'm assuming it works until someone files a bug on it ;-)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.