312572 - Simplify syntax error handling/logging in IMAP parsing

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

The following simplifications can implemented easily and without
changing any behavior of the IMAP implementation.

* remove field |nsIMAPGenericParser::fSyntaxErrorLine|
* remove method |nsIMAPGenericParser::::CreateSyntaxErrorLine()|

Comment 1

[Hans-Andreas Engel]

Attachment: Simplify syntax error handling/logging in IMAP parsing

Comment 2

[David :Bienvenu]

Comment on attachment 199684 [details] [diff] [review]
Simplify syntax error handling/logging in IMAP parsing

looks good - I'll try running with this, though I don't often have contact with
servers that cause syntax errors :-)

Comment 3

[David :Bienvenu]

fixed, thx, Hans. Sorry, I forgot to credit you in my checkin comment :-(

Comment 4

[Hans-Andreas Engel]

Regarding the incomplete checkin comment: No Problem!  (Anyway, it was a trivial
patch, only leading to a small improvement of the code.)

David, thank you for the timely processing of this bug!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm doing an LXR verification of this, because to be honest I'm assuming it works until someone files a bug on it ;-)