312591 - draggesture fires when mousebutton is already released

Status: RESOLVED INCOMPLETE

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Shane Caraveo]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

in our draggable tabbox (not the same as in firefox) I get a draggesture event
if I click on a tab (releasing mouse button) and move the mouse quickly.  The
attached patch will prevent this without impairing drag/drop

Reproducible: Always

Steps to Reproduce:

Comment 1

[Shane Caraveo]

Attachment: draggesture.patch

Comment 2

[Simon Fraser [no longer active]]

I think we have other bugs about it being too easy to start a drag.

Also, I don't think we'll take the patch in its current form. We should avoid
platform #ifdefs in XP code.

Comment 3

[Mark Mentovai]

Comment on attachment 199698 [details] [diff] [review]
draggesture.patch

+    if (StillDown()) // only generate drag gesture if button is down

::StillDown(), please.

We have other Mac-specific StillDown() hackiness already in this file.  Why are we only having trouble figuring out whether the button is down on the Mac?

Comment 4

[Shane Caraveo]

Attachment: draggesture.patch

this actually is a bit better, prevents calling updatecursor and GenerateMouseEnterExit in addition to GenerateDragGesture.

Comment 5

[Shane Caraveo]

Attachment: oops on the last one, draggesture.patch

Comment 6

[Shane Caraveo]

Comment on attachment 213671 [details] [diff] [review]
draggesture.patch

this *is* actually the correct patch, a brain fart made be do the other bad patch

Comment 7

[Shane Caraveo]

Comment on attachment 213673 [details] [diff] [review]
oops on the last one, draggesture.patch

bad bad patch

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Shane, is this still a problem in recent Gecko versions?

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #8)
> Shane, is this still a problem in recent Gecko versions?