[BeOS]Fixing warnings at nsWindows.cpp compilation

RESOLVED FIXED

Status

Core Graveyard
Widget: BeOS
RESOLVED FIXED
13 years ago
4 years ago

People

(Reporter: Sergei Dolgov, Assigned: Sergei Dolgov)

Tracking

({fixed1.8.1})

Trunk
x86
BeOS
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
There are warnings about unused cursor types, and warning about using temporary
in suspicious place - when initialising event for DnD.
Path to fix is clear - add cases for exisiting but unused cursors in SetCursor,
add nsRect point; for DnD event, as it is done in all other events
(Assignee)

Comment 1

13 years ago
Created attachment 199756 [details] [diff] [review]
patch

in additioned to mentioned above, two more warings about float->nscoord
conversion fixed
Attachment #199756 - Flags: review?(thesuckiestemail)

Comment 2

13 years ago
Comment on attachment 199756 [details] [diff] [review]
patch

r=thesuckiestemail@yahoo.se
Attachment #199756 - Flags: review?(thesuckiestemail) → review+
(Assignee)

Comment 3

13 years ago
landed in trunk
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.101; previous revision: 1.100
done  
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
Created attachment 230248 [details] [diff] [review]
Patch for 1_8 branch

Requesting approval for this patch. It is the same as the trunk patch, except that some nsEvent variables have different names. 

This is a BeOS change only and will not affect other platforms.
Attachment #230248 - Flags: approval1.8.1?
Comment on attachment 230248 [details] [diff] [review]
Patch for 1_8 branch

a=drivers. Please go ahead and land this on the branch.
Attachment #230248 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 6

12 years ago
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.11; previous revision: 1.91.4.10
done 
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.