312788 - Crash exposing invisible plugins

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

If a plugin has a width or height of 0 Firefox crashes while exposing the MSAA.

In any case, we don't want to expose invisible content via MSAA.

Comment 1

[Aaron Leventhal]

Attachment: Testcase. If the width and height are made non-zero then it does not crash when MSAA tools are used with it.

Comment 2

[Aaron Leventhal]

Attachment: Testcase. If the width and height are made non-zero then it does not crash when MSAA tools are used with it.

Comment 3

[Aaron Leventhal]

Attachment: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class)

Comment 4

[Aaron Leventhal]

This is important because invisible plugins are used to expose audio content,
for example on BBC's "listen live" links.

Comment 5

[Scott MacGregor]

We're not going to block the release on this, but if this patch gets super
reviewed by jst, laned on the trunk and verified in the next couple of days,
nominate the patch for branch approval. Thanks.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 199889 [details] [diff] [review]
Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class)

sr=jst too fwiw.

Comment 7

[Dan Kinnunen]

Verified that this has been fixed in dev build 10/19/05 build from aaron.

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381