The default bug view has changed. See this FAQ.

Crash exposing invisible plugins

VERIFIED FIXED

Status

()

Core
Disability Access APIs
--
critical
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, fixed1.8, sec508})

Trunk
x86
Windows XP
access, fixed1.8, sec508
Points:
---
Bug Flags:
blocking1.8rc1 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
If a plugin has a width or height of 0 Firefox crashes while exposing the MSAA.

In any case, we don't want to expose invisible content via MSAA.
(Assignee)

Comment 1

12 years ago
Created attachment 199887 [details] [diff] [review]
Testcase. If the width and height are made non-zero then it does not crash when MSAA tools are used with it.
(Assignee)

Comment 2

12 years ago
Created attachment 199888 [details]
Testcase. If the width and height are made non-zero then it does not crash when MSAA tools are used with it.
(Assignee)

Updated

12 years ago
Attachment #199887 - Attachment is obsolete: true
(Assignee)

Comment 3

12 years ago
Created attachment 199889 [details] [diff] [review]
Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class)
Attachment #199889 - Flags: superreview?(jst)
Attachment #199889 - Flags: review?(parente)
(Assignee)

Comment 4

12 years ago
This is important because invisible plugins are used to expose audio content,
for example on BBC's "listen live" links.
Severity: normal → critical
Status: NEW → ASSIGNED

Updated

12 years ago
Attachment #199889 - Flags: review?(parente) → review+
(Assignee)

Updated

12 years ago
Flags: blocking1.8rc1?

Comment 5

12 years ago
We're not going to block the release on this, but if this patch gets super
reviewed by jst, laned on the trunk and verified in the next couple of days,
nominate the patch for branch approval. Thanks.
Flags: blocking1.8rc1? → blocking1.8rc1-
(Assignee)

Updated

12 years ago
Attachment #199889 - Flags: superreview?(jst) → superreview?(bzbarsky)
Attachment #199889 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 199889 [details] [diff] [review]
Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class)

sr=jst too fwiw.
(Assignee)

Updated

12 years ago
Attachment #199889 - Flags: approval1.8rc1?

Updated

12 years ago
Attachment #199889 - Flags: approval1.8rc1? → approval1.8rc1+

Comment 7

12 years ago
Verified that this has been fixed in dev build 10/19/05 build from aaron.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

12 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.