Closed Bug 312792 Opened 16 years ago Closed 16 years ago
Crash exposing dynamically changing <option> lists
We're not setting the end of the list correctly when we cache a group of <option>'s. As a result, options lists can crash when you get next sibling. Steps to repro: 1. Launch Window-Eyes 2. Go to http://www.creative.com/language.asp 3. Type Ctrl+Shift+A to turn off browse mode 4. Click on the first list 5. Down arrow Firefox will crash
Comment on attachment 199894 [details] [diff] [review] SetNextSibling(nsnull) on the last <option> cached sr=bzbarsky, but I have to confess I have no idea what this code is doing (and no time to sort it out).
Comment on attachment 199894 [details] [diff] [review] SetNextSibling(nsnull) on the last <option> cached Do you need to check if the QI succeeds on lastGoodAccessible before using it?
Attachment #199894 - Flags: review?(parente) → review+
(In reply to comment #3) > (From update of attachment 199894 [details] [diff] [review] ) > Do you need to check if the QI succeeds on lastGoodAccessible before using it? No, it will always succeed. We put assertions in sometimes but it will never get hit.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
This has been tested by GW Micro in a special build created for them.
Verified that this has been fixed in dev build 10/18/05 build from aaron.
Verified by Doug Geoffray from GW Micro.
Status: RESOLVED → VERIFIED
Attachment #199894 - Flags: approval1.8rc1? → approval1.8rc1+
You need to log in before you can comment on or make changes to this bug.