Closed Bug 312792 Opened 15 years ago Closed 15 years ago

Crash exposing dynamically changing <option> lists

Categories

(Core :: Disability Access APIs, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

References

()

Details

(Keywords: access, fixed1.8)

Attachments

(1 file)

We're not setting the end of the list correctly when we cache a group of <option>'s.

As a result, options lists can crash when you get next sibling.

Steps to repro:
1. Launch Window-Eyes
2. Go to http://www.creative.com/language.asp
3. Type Ctrl+Shift+A to turn off browse mode
4. Click on the first list
5. Down arrow

Firefox will crash
Attachment #199894 - Flags: superreview?(bzbarsky)
Attachment #199894 - Flags: review?(bzbarsky)
Comment on attachment 199894 [details] [diff] [review]
SetNextSibling(nsnull) on the last <option> cached

sr=bzbarsky, but I have to confess I have no idea what this code is doing (and
no time to sort it out).
Attachment #199894 - Flags: superreview?(bzbarsky)
Attachment #199894 - Flags: superreview+
Attachment #199894 - Flags: review?(bzbarsky)
Attachment #199894 - Flags: review?(parente)
Comment on attachment 199894 [details] [diff] [review]
SetNextSibling(nsnull) on the last <option> cached

Do you need to check if the QI succeeds on lastGoodAccessible before using it?
Attachment #199894 - Flags: review?(parente) → review+
(In reply to comment #3)
> (From update of attachment 199894 [details] [diff] [review] [edit])
> Do you need to check if the QI succeeds on lastGoodAccessible before using it?

No, it will always succeed. We put assertions in sometimes but it will never get
hit.
Attachment #199894 - Flags: approval1.8rc1?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This has been tested by GW Micro in a special build created for them.
Verified that this has been fixed in dev build 10/18/05 build from aaron.
Verified by Doug Geoffray from GW Micro.
Status: RESOLVED → VERIFIED
Attachment #199894 - Flags: approval1.8rc1? → approval1.8rc1+
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.