312952 - Handle IMAP input "NIL)" correctly.

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

In almost all cases when |CreateNilString()| is called, it is followed by
|AdvanceToNextToken()|.  If the token would be |NIL)|, this means that the ')'
would erroneously be overlooked by the parser.
   Also note that a token like |"quoted")|, the ')' would be properly retained.

This bug required the following kludge.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp&rev=1.129&root=/cvsroot&mark=1525-1529#1520

Bug and kludge should be removed.

Comment 1

[Hans-Andreas Engel]

Also, there might be some kludges in |nsImapServerResponseParser::envelope_data()|,
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp&rev=1.129&root=/cvsroot&mark=1405,1426-1428#1400

However, it seems to me that this code for parsing an ENVELOPE response is not
in use (it should probably still be kept for a more complete implementation of
the IMAP protocol), because neither FETCH ENVELOPE nor FETCH ALL is ever
requested from the server,
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.615&root=/cvsroot#2799

Comment 2

[Hans-Andreas Engel]

The kludge in |nsImapServerResponseParser::envelope_data()| originates from the
patch to Bug 41236,
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/imap/src&command=DIFF_FRAMESET&file=nsImapServerResponseParser.cpp&rev2=1.62&rev1=1.61

Comment 3

[Hans-Andreas Engel]

Attachment: fix |CreateNilString|, remove two kludges

(Note that both kludges were relevant only if |envelope_data()| was invoked.)

Comment 4

[David :Bienvenu]

Comment on attachment 200037 [details] [diff] [review]
fix |CreateNilString|, remove two kludges

thanks, Hans-A

Comment 5

[Hans-Andreas Engel]

This patch is not yet applied (only the comment with the definition of envelope data is in the CVS).

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/imap/src/nsIMAPGenericParser.cpp&rev=1.51&mark=303-304#294

Comment 6

[Hans-Andreas Engel]

Attachment: fix |CreateNilString|, remove two kludges (updated patch to match current codebase)

Comment 7

[David :Bienvenu]

fix checked in, thx, Hans-Andreas!