Camino 2005101814 (v1.0a1+) STR: 1. Visit site above 2. Drag blue globe from tab to BM Bar to create new bookmark 3. After bookmark is created, hover over bookmark Results: A few seconds of nothing and then beachball and shortly Activity Monitor reports Camino is hung Expected: Tooltip with full bookmark name and URL Sample to follow.
Not sure if today's branch build being so late means anything, but I experienced this on yesterday's branch build, too.
14 years ago
Summary: Hovering over newly-added BM Bar bookmark casues Camino to hang. → Hovering over newly-added BM Bar bookmark causes Camino to hang.
Definitely needs to block. This should block beta.
Flags: camino1.0? → camino1.0+
Target Milestone: --- → Camino1.0
It's hanging in -[NSToolTipManager displayToolTip:]. Ugh.
Assignee: mikepinkerton → sfraser_bugs
Turns out that using "\n\n" as a tooltip string hangs Cocoa.
Status: NEW → ASSIGNED
Patch first avoids the problem by inserting the bookmark after settings its properties, and secondly checks the tooltip string to make sure it's not "\n\n".
+ [theBookmark release]; + [self insertChild:theBookmark atIndex:aPosition isMove:NO]; These two lines should be swapped in the patch.
Comment on attachment 200051 [details] [diff] [review] Patch + if (![tooltipString isEqualToString:@"\n\n"]) + [self setToolTip:]; Set it to what?
Comment on attachment 200094 [details] [diff] [review] Patch v. 2 Nice.
Attachment #200094 - Flags: review?(mark) → review+
Actually, if @"\n\n" is bad, then any other number of @"\n" might also be a problem. This could bite us again if the tooltip format ever changes.
Fixed on trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.