312959 - Hovering over newly-added BM Bar bookmark causes Camino to hang.

Status: RESOLVED FIXED

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Camino 2005101814 (v1.0a1+)

STR:
1. Visit site above
2. Drag blue globe from tab to BM Bar to create new bookmark
3. After bookmark is created, hover over bookmark

Results:
A few seconds of nothing and then beachball and shortly Activity Monitor reports
Camino is hung

Expected:
Tooltip with full bookmark name and URL

Sample to follow.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Created attachment 200046 [details]
Sample of Camino hanging

Not sure if today's branch build being so late means anything, but I
experienced this on yesterday's branch build, too.

Comment 2

[Samuel Sidler (old account; do not CC)]

Definitely needs to block. This should block beta.

Comment 3

[Simon Fraser]

It's hanging in -[NSToolTipManager displayToolTip:]. Ugh.

Comment 4

[Simon Fraser]

Turns out that using "\n\n" as a tooltip string hangs Cocoa.

Comment 5

[Simon Fraser]

Created attachment 200051 [details] [diff] [review]
Patch

Patch first avoids the problem by inserting the bookmark after settings its
properties, and secondly checks the tooltip string to make sure it's not
"\n\n".

Comment 6

[Simon Fraser]

+    [theBookmark release];
+    [self insertChild:theBookmark atIndex:aPosition isMove:NO];

These two lines should be swapped in the patch.

Comment 7

[Mark Mentovai]

Comment on attachment 200051 [details] [diff] [review]
Patch

+    if (![tooltipString isEqualToString:@"\n\n"])
+      [self setToolTip:];

Set it to what?

Comment 8

[Simon Fraser]

Created attachment 200094 [details] [diff] [review]
Patch v. 2

Comment 9

[Mark Mentovai]

Comment on attachment 200094 [details] [diff] [review]
Patch v. 2

Nice.

Comment 10

[Mark Mentovai]

Actually, if @"\n\n" is bad, then any other number of @"\n" might also be a
problem.  This could bite us again if the tooltip format ever changes.

Comment 11

[Simon Fraser]

Fixed on trunk and branch.