Hovering over newly-added BM Bar bookmark causes Camino to hang.
RESOLVED
FIXED
in Camino1.0
Status
Camino Graveyard
Toolbars & Menus
--
critical
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: sfraser_bugs)
Tracking
({fixed1.8, hang})
Bug Flags:
Details
(URL)
Attachments
(2 attachments, 1 obsolete attachment)
39.82 KB,
text/plain
|
Details | |
2.87 KB,
patch
|
mark
:
review+
|
Details | Diff | Splinter Review |
Camino 2005101814 (v1.0a1+) STR: 1. Visit site above 2. Drag blue globe from tab to BM Bar to create new bookmark 3. After bookmark is created, hover over bookmark Results: A few seconds of nothing and then beachball and shortly Activity Monitor reports Camino is hung Expected: Tooltip with full bookmark name and URL Sample to follow.
(Reporter) | ||
Comment 1•14 years ago
|
||
Created attachment 200046 [details]
Sample of Camino hanging
Not sure if today's branch build being so late means anything, but I
experienced this on yesterday's branch build, too.
(Reporter) | ||
Updated•14 years ago
|
Flags: camino1.0?
Updated•14 years ago
|
Summary: Hovering over newly-added BM Bar bookmark casues Camino to hang. → Hovering over newly-added BM Bar bookmark causes Camino to hang.
Comment 2•14 years ago
|
||
Definitely needs to block. This should block beta.
Flags: camino1.0? → camino1.0+
Target Milestone: --- → Camino1.0
(Assignee) | ||
Comment 3•14 years ago
|
||
It's hanging in -[NSToolTipManager displayToolTip:]. Ugh.
Assignee: mikepinkerton → sfraser_bugs
(Assignee) | ||
Comment 4•14 years ago
|
||
Turns out that using "\n\n" as a tooltip string hangs Cocoa.
Status: NEW → ASSIGNED
(Assignee) | ||
Comment 5•14 years ago
|
||
Created attachment 200051 [details] [diff] [review] Patch Patch first avoids the problem by inserting the bookmark after settings its properties, and secondly checks the tooltip string to make sure it's not "\n\n".
(Assignee) | ||
Comment 6•14 years ago
|
||
+ [theBookmark release]; + [self insertChild:theBookmark atIndex:aPosition isMove:NO]; These two lines should be swapped in the patch.
Comment 7•14 years ago
|
||
Comment on attachment 200051 [details] [diff] [review] Patch + if (![tooltipString isEqualToString:@"\n\n"]) + [self setToolTip:]; Set it to what?
(Assignee) | ||
Comment 8•14 years ago
|
||
Created attachment 200094 [details] [diff] [review] Patch v. 2
Attachment #200051 -
Attachment is obsolete: true
Attachment #200094 -
Flags: review?(mark)
Comment 9•14 years ago
|
||
Comment on attachment 200094 [details] [diff] [review] Patch v. 2 Nice.
Attachment #200094 -
Flags: review?(mark) → review+
Comment 10•14 years ago
|
||
Actually, if @"\n\n" is bad, then any other number of @"\n" might also be a problem. This could bite us again if the tooltip format ever changes.
(Assignee) | ||
Comment 11•14 years ago
|
||
Fixed on trunk and branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•