Use classes instead of pseudo elements

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
10 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

9.02 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Until bug 271724 is fixed, I think we should put f.x. a class="xf-value" on the
value elements, and also change @repeat-index to a class instead.
(Assignee)

Comment 1

12 years ago
Created attachment 200778 [details] [diff] [review]
Patch

* sets the class "xf-value" (should be ::value) on elements where it makes sense
* changes nsXFormsContentContainer to use @class too, and also sets "repeat-item" class (which should be ::repeat-item)
Attachment #200778 - Flags: review?(doronr)

Comment 2

12 years ago
Comment on attachment 200778 [details] [diff] [review]
Patch

> 
>   <!-- UPLOAD: DISABLED -->
>   <binding id="xformswidget-upload-disabled"
>            extends="chrome://xforms/content/xforms.xml#xformswidget-base">
>     <content>
>       <children includes="label"/>
>       <html:input readonly="true"
>+                  class="value"

you want xf-value probably!
Attachment #200778 - Flags: review?(doronr) → review-
(Assignee)

Comment 3

12 years ago
Created attachment 200779 [details] [diff] [review]
Patch v2

(In reply to comment #2)
> (From update of attachment 200778 [details] [diff] [review] [edit])
> > 
> >   <!-- UPLOAD: DISABLED -->
> >   <binding id="xformswidget-upload-disabled"
> >            extends="chrome://xforms/content/xforms.xml#xformswidget-base">
> >     <content>
> >       <children includes="label"/>
> >       <html:input readonly="true"
> >+                  class="value"
> 
> you want xf-value probably!

No! I _hate_ upload. It should be punished! Take that you lousy control!

... or yes :-)
Attachment #200778 - Attachment is obsolete: true
Attachment #200779 - Flags: review?(doronr)

Updated

12 years ago
Attachment #200779 - Flags: review?(doronr) → review+
(Assignee)

Updated

12 years ago
Attachment #200779 - Flags: review?(smaug)

Comment 4

12 years ago
Comment on attachment 200779 [details] [diff] [review]
Patch v2


>  */
> NS_IMETHODIMP
> nsXFormsContextContainer::SetIndexState(PRBool aHasIndex)
> {
>   if (mElement) {
>-    NS_NAMED_LITERAL_STRING(repIndex, "repeat-index");
>+    mHasIndex = aHasIndex;
>+    NS_NAMED_LITERAL_STRING(classStr, "class");
>     if (aHasIndex) {
>-      mElement->SetAttribute(repIndex,
>-                             NS_LITERAL_STRING("1"));
>+      mElement->SetAttribute(classStr,
>+                             NS_LITERAL_STRING("repeat-item repeat-index"));
>     } else {
>-      mElement->RemoveAttribute(repIndex);
>+      mElement->SetAttribute(classStr, NS_LITERAL_STRING("repeat-item"));
>     }

xf-repeat-item and xf-repeat-index

With those, r=me
Attachment #200779 - Flags: review?(smaug) → review+
(Assignee)

Comment 5

12 years ago
Created attachment 200782 [details] [diff] [review]
With Olli's comment fixed
Attachment #200779 - Attachment is obsolete: true
(Assignee)

Comment 6

12 years ago
Checked in to trunk
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch

Comment 7

12 years ago
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED

Comment 8

11 years ago
verfied fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.