313015 - With find dialog focussed, cmd-w closes tab instead of dialog when multiple tabs open

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect, P2)

Description

[Samuel Sidler (old account; do not CC)]

As the summary says, however, note that this works when there is only one tab
(or just a window with no tabs) open and properly closes the dialog instead of
the window.

STR:
1. Open two tabs
2. Press cmd-f to open the Find dialog
3. Make sure dialog has focus
4. Press cmd-w

Results:
The tab which was open closes.

Expected results:
The find dialog should close.

Comment 1

[Chris Lawson (gone)]

Further comment: hitting ESC will close the Find window, but not the tab. I
discovered this by accident the other night. Until then, it had been driving me
nuts. Now it's just driving me mildly nuts, since I know a workaround. :)

cl

Comment 2

[Simon Fraser [no longer active]]

Mine.

Comment 3

[Simon Fraser [no longer active]]

Attachment: Patch

Fix is to look at the key window, not the main window, when updating the Close
Window command.

Comment 4

[Simon Fraser [no longer active]]

Fixed on trunk and branch.

Comment 5

[Chris Lawson (gone)]

This doesn't only happen with the Find dialog. I can get it to happen with the
bookmark "Get Info" window, too. The same workaround applies.

Haven't checked to see if Simon's fix solves this problem too, but I expect it will.

cl

Comment 6

[Simon Fraser [no longer active]]

Yep, it does.