313025 - When Camino is hidden with multiple tabs, attempting to quit it should unhide it with confirm-close-on-quit dialog

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Samuel Sidler (old account; do not CC)]

If a user has a window with multiple tabs and hides Camino, then selects "Quit"
from the dock icon menu, Camino should re-appear from it's hide and bring up the
"Confirm Multiple Tab Close" allowing the user to confirm before they close.

STR:
1. Open multiple tabs
2. Hide Camino
3. Select Quit from Camino's dock icon

Actual Results:
Camino's dock icon just bounces.

Expected Results:
Camino should come back from hiding with the dialog up.

Comment 1

[Simon Fraser [no longer active]]

I'm not sure how to fix this. We're stuck inside of -runModalForWindow.

Comment 2

[JK]

The same happens if one uses COMMAND+TAB to select Camino then hit Q without
releasing COMMAND.

Comment 3

[Wevah (Nate Weaver)]

Are we/should we be calling makeKeyAndOrderFront: on the window first?

Comment 4

[Simon Fraser [no longer active]]

(In reply to comment #3)
> Are we/should we be calling makeKeyAndOrderFront: on the window first?

We aren't, and should not be (according to the docs).

Comment 5

[Simon Fraser [no longer active]]

Attachment: Patch to activate the app before showing the dialog

I think this is the safest way; activate the app before showing the dialog. I
tried running an NSRunAlertPanel() in a test app in the same way, and it does
activate the app.

Comment 6

[Simon Fraser [no longer active]]

Fixed on trunk and branch.