Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Crash when using AccessibleObjectFromWindow

RESOLVED FIXED

Status

()

Core
Disability Access APIs
--
critical
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, fixed1.8})

Trunk
x86
All
access, fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Occasionally when using AccessibleObjectFromWindow() a crash will occur. The
base cause is a whole bunch of unnecessary calls when we try to return the
native accessible for the window.

The system's impl of AccessibleObjectFromWindow() uses get_accParent(), and our
get_accParent() will return the native OBJID_WINDOW accessible. We're supposed
to ignore those calls, but we are getting the root accessible at that point
which is unnecessary. Removing that clears up the unnecessary calls and the crash.
(Assignee)

Comment 1

12 years ago
Created attachment 200120 [details] [diff] [review]
Patch without whitespace changes. It will be checked in with correct indentation.
Attachment #200120 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #200120 - Flags: superreview?(jst)
Attachment #200120 - Flags: review?(parente)
Attachment #200120 - Flags: review?

Updated

12 years ago
Attachment #200120 - Flags: review?(parente) → review+
(Assignee)

Updated

12 years ago
Attachment #200120 - Flags: superreview?(jst) → superreview?(bzbarsky)

Comment 2

12 years ago
Comment on attachment 200120 [details] [diff] [review]
Patch without whitespace changes. It will be checked in with correct indentation.

Sure...
Attachment #200120 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Updated

12 years ago
Attachment #200120 - Flags: approval1.8rc1?
(Assignee)

Comment 3

12 years ago
This is not risky. It just moves the GetRootAccessible into the 2 if () sections
that use the results. Please take for branch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #200120 - Flags: approval1.8rc1? → approval1.8rc1+

Comment 4

12 years ago
Verified that this has been fixed in dev build 10/19/05 build
(Assignee)

Updated

12 years ago
Keywords: fixed1.8

Comment 5

12 years ago
Note: this fails to compile with --with-windows-version=400
You need to log in before you can comment on or make changes to this bug.