Closed
Bug 313043
Opened 20 years ago
Closed 20 years ago
Crash when using AccessibleObjectFromWindow
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access, fixed1.8)
Attachments
(1 file)
|
1.77 KB,
patch
|
parente
:
review+
bzbarsky
:
superreview+
asa
:
approval1.8rc1+
|
Details | Diff | Splinter Review |
Occasionally when using AccessibleObjectFromWindow() a crash will occur. The
base cause is a whole bunch of unnecessary calls when we try to return the
native accessible for the window.
The system's impl of AccessibleObjectFromWindow() uses get_accParent(), and our
get_accParent() will return the native OBJID_WINDOW accessible. We're supposed
to ignore those calls, but we are getting the root accessible at that point
which is unnecessary. Removing that clears up the unnecessary calls and the crash.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #200120 -
Flags: review?
|
|
Assignee | |
Updated•20 years ago
|
Attachment #200120 -
Flags: superreview?(jst)
Attachment #200120 -
Flags: review?(parente)
Attachment #200120 -
Flags: review?
Attachment #200120 -
Flags: review?(parente) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #200120 -
Flags: superreview?(jst) → superreview?(bzbarsky)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 200120 [details] [diff] [review]
Patch without whitespace changes. It will be checked in with correct indentation.
Sure...
Attachment #200120 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #200120 -
Flags: approval1.8rc1?
|
|
Assignee | |
Comment 3•20 years ago
|
||
This is not risky. It just moves the GetRootAccessible into the 2 if () sections
that use the results. Please take for branch.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Attachment #200120 -
Flags: approval1.8rc1? → approval1.8rc1+
|
||
Comment 4•20 years ago
|
||
Verified that this has been fixed in dev build 10/19/05 build
|
||
Comment 5•19 years ago
|
||
Note: this fails to compile with --with-windows-version=400
You need to log in
before you can comment on or make changes to this bug.
Description
•