Closed
Bug 313157
Opened 19 years ago
Closed 19 years ago
[FIX]Avoid nsIClassInfo::GetClassDescription where possible
Categories
(Core :: Security: CAPS, defect, P1)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
9.50 KB,
patch
|
dveditz
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Until bug 311600 is fixed, which I doubt will happen any time soon, I think
security manager should avoid calling GetClassName on the classinfo unless it
has to. We only need this if there is a non-default domain policy for the
subject principal or the very first time per given XPConnect scope that we look
at a given class -- after that the default class policy is cached in the
securityinfo on the XPConnect prototype.
Patch coming up; this cuts the time CheckPropertyAccessImpl takes by about 30%
whenever we can avoid calling GetClassName.
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•19 years ago
|
Summary: [FIX]Avoid nsIClassInfo::GetClassName where possible → [FIX]Avoid nsIClassInfo::GetClassDescription where possible
|
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #200222 -
Flags: superreview?(jst)
Attachment #200222 -
Flags: review?(dveditz)
|
||
Comment 2•19 years ago
|
||
Caillon: could you look at this one, too, please?
|
|
||
Comment 3•19 years ago
|
||
Comment on attachment 200222 [details] [diff] [review]
Patch as described
r=dveditz looks good
Attachment #200222 -
Flags: review?(dveditz) → review+
|
||
Comment 4•19 years ago
|
||
Comment on attachment 200222 [details] [diff] [review]
Patch as described
Nice! sr=jst
Attachment #200222 -
Flags: superreview?(jst) → superreview+
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 200222 [details] [diff] [review]
Patch as described
Nice! sr=jst
|
|
Assignee | |
Comment 6•19 years ago
|
||
Fixed. This improved Tdhtml by about 2%.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•