Closed Bug 313157 Opened 19 years ago Closed 19 years ago

[FIX]Avoid nsIClassInfo::GetClassDescription where possible

Categories

(Core :: Security: CAPS, defect, P1)

Product:
Core
Component:
Security: CAPS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: perf)

Attachments

(1 file)

Patch as described
9.50 KB, patch
dveditz
: review+
jst
: superreview+
Details | Diff | Splinter Review 
Until bug 311600 is fixed, which I doubt will happen any time soon, I think
security manager should avoid calling GetClassName on the classinfo unless it
has to.  We only need this if there is a non-default domain policy for the
subject principal or the very first time per given XPConnect scope that we look
at a given class -- after that the default class policy is cached in the
securityinfo on the XPConnect prototype.

Patch coming up; this cuts the time CheckPropertyAccessImpl takes by about 30%
whenever we can avoid calling GetClassName.
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Summary: [FIX]Avoid nsIClassInfo::GetClassName where possible → [FIX]Avoid nsIClassInfo::GetClassDescription where possible

    
  

        Attachment #200222 -
        Flags: superreview?(jst)

        Attachment #200222 -
        Flags: review?(dveditz)

    
  
Blocks: 311600

    
    

    
  
Caillon: could you look at this one, too, please?

    
    

    
  
Comment on attachment 200222 [details] [diff] [review]
Patch as described

r=dveditz looks good

        Attachment #200222 -
        Flags: review?(dveditz) → review+

    
    

    
  
Comment on attachment 200222 [details] [diff] [review]
Patch as described

Nice! sr=jst

        Attachment #200222 -
        Flags: superreview?(jst) → superreview+

    
    

    
  
Comment on attachment 200222 [details] [diff] [review]
Patch as described

Nice! sr=jst

    
    

    
  
Fixed.  This improved Tdhtml by about 2%.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: