Last Comment Bug 313165 - Infinite loop in text frame getBBox
: Infinite loop in text frame getBBox
Status: RESOLVED FIXED
: fixed1.8
Product: Core
Classification: Components
Component: SVG (show other bugs)
: 1.8 Branch
: All All
: -- normal (vote)
: ---
Assigned To: tor
: Hixie (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-20 10:21 PDT by tor
Modified: 2005-10-26 16:49 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase - will hang branch browser (343 bytes, image/svg+xml)
2005-10-20 10:22 PDT, tor
no flags Details
fix logic (1.77 KB, patch)
2005-10-20 10:23 PDT, tor
no flags Details | Diff | Splinter Review
diff -w version of patch for review purposes (1.40 KB, patch)
2005-10-20 10:23 PDT, tor
roc: review+
roc: superreview+
asa: approval1.8rc1+
Details | Diff | Splinter Review

Description tor 2005-10-20 10:21:38 PDT
Logic problem in nsSVGTextFrame::GetBBox causes an infinite loop if a child
doesn't return a bounding box, such as <svg:title>'s generic SVG frame.

Trunk doesn't have this problem as its GetBBox uses the common version in
nsSVGUtils.
Comment 1 tor 2005-10-20 10:22:43 PDT
Created attachment 200229 [details]
testcase - will hang branch browser
Comment 2 tor 2005-10-20 10:23:18 PDT
Created attachment 200230 [details] [diff] [review]
fix logic
Comment 3 tor 2005-10-20 10:23:58 PDT
Created attachment 200232 [details] [diff] [review]
diff -w version of patch for review purposes
Comment 4 Robert O'Callahan (:roc) (email my personal email if necessary) 2005-10-21 13:35:45 PDT
Comment on attachment 200232 [details] [diff] [review]
diff -w version of patch for review purposes

this fix is trivial, nearly zero risk
Comment 5 tor 2005-10-23 14:11:06 PDT
Checked in on branch.

Note You need to log in before you can comment on or make changes to this bug.