The default bug view has changed. See this FAQ.

Infinite loop in text frame getBBox

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

({fixed1.8})

1.8 Branch
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

12 years ago
Logic problem in nsSVGTextFrame::GetBBox causes an infinite loop if a child
doesn't return a bounding box, such as <svg:title>'s generic SVG frame.

Trunk doesn't have this problem as its GetBBox uses the common version in
nsSVGUtils.
(Assignee)

Comment 1

12 years ago
Created attachment 200229 [details]
testcase - will hang branch browser
(Assignee)

Comment 2

12 years ago
Created attachment 200230 [details] [diff] [review]
fix logic
(Assignee)

Comment 3

12 years ago
Created attachment 200232 [details] [diff] [review]
diff -w version of patch for review purposes
Attachment #200232 - Flags: review?(jonathan.watt)
(Assignee)

Updated

12 years ago
Attachment #200232 - Flags: review?(jonathan.watt) → review?(roc)
Comment on attachment 200232 [details] [diff] [review]
diff -w version of patch for review purposes

this fix is trivial, nearly zero risk
Attachment #200232 - Flags: superreview+
Attachment #200232 - Flags: review?(roc)
Attachment #200232 - Flags: review+
Attachment #200232 - Flags: approval1.8rc1?

Updated

12 years ago
Attachment #200232 - Flags: approval1.8rc1? → approval1.8rc1+
(Assignee)

Comment 5

12 years ago
Checked in on branch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.