Closed
Bug 313192
Opened 19 years ago
Closed 19 years ago
Fix attribute "leftovers" from bug 271720
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
5.07 KB,
patch
|
doronr
:
review+
aaronr
:
review+
|
Details | Diff | Splinter Review |
I apparently forgot a few things in bug 271720. These still check for attributes: - nsXFormsControlStubBase::GetReadOnlyState() - nsXFormsControlStubBase::GetRelevantState() - nsXFormsDelegateStub::GetState() (and its friends) They need to get to the nodestate from the model, which is not possible right now. One approach is to expose the nsXFormsMDGEngine::GetNodeState(), which I would go for now. Another approach is to do the more versatile solution which is also wanted in bug 313113, but let's wait with that.
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•19 years ago
|
||
Ok, this is no beauty, but if we want it in for 1.5rc1, this is what I can supply right now. What should be tested is that delegate.isReadonly(), delegate.isEnabled(), etc. work properly. This should be done properly by the major overhaul of handling the states as I write in bug 300591 comment 3.
Attachment #200362 -
Flags: review?(doronr)
|
||
Updated•19 years ago
|
Attachment #200362 -
Flags: review?(doronr) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #200362 -
Flags: review?(aaronr)
Attachment #200362 -
Flags: review?(aaronr) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in to 1.8 branch
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•