The default bug view has changed. See this FAQ.

Fix attribute "leftovers" from bug 271720

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
8 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8})

Trunk
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

5.07 KB, patch
Doron Rosenberg (IBM)
: review+
aaronr
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
I apparently forgot a few things in bug 271720. These still check for attributes:
- nsXFormsControlStubBase::GetReadOnlyState()
- nsXFormsControlStubBase::GetRelevantState()
- nsXFormsDelegateStub::GetState() (and its friends)

They need to get to the nodestate from the model, which is not possible right
now. One approach is to expose the nsXFormsMDGEngine::GetNodeState(), which I
would go for now.

Another approach is to do the more versatile solution which is also wanted in
bug 313113, but let's wait with that.
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

12 years ago
Created attachment 200362 [details] [diff] [review]
Patch

Ok, this is no beauty, but if we want it in for 1.5rc1, this is what I can
supply right now. What should be tested is that delegate.isReadonly(),
delegate.isEnabled(), etc. work properly.

This should be done properly by the major overhaul of handling the states as I
write in bug 300591 comment 3.
Attachment #200362 - Flags: review?(doronr)

Updated

12 years ago
Attachment #200362 - Flags: review?(doronr) → review+
(Assignee)

Updated

12 years ago
Attachment #200362 - Flags: review?(aaronr)

Updated

12 years ago
Attachment #200362 - Flags: review?(aaronr) → review+
(Assignee)

Comment 2

12 years ago
Checked in to trunk
Whiteboard: xf-to-branch
(Assignee)

Comment 3

12 years ago
Checked in to 1.8 branch
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

Updated

12 years ago
Keywords: fixed1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.