Last Comment Bug 313192 - Fix attribute "leftovers" from bug 271720
: Fix attribute "leftovers" from bug 271720
: fixed1.8
Product: Core Graveyard
Classification: Graveyard
Component: XForms (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Allan Beaufour
: Stephen Pride
Depends on:
  Show dependency treegraph
Reported: 2005-10-20 14:12 PDT by Allan Beaufour
Modified: 2016-07-15 14:46 PDT (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (5.07 KB, patch)
2005-10-21 10:20 PDT, Allan Beaufour
doronr: review+
aaronr: review+
Details | Diff | Splinter Review

Description User image Allan Beaufour 2005-10-20 14:12:37 PDT
I apparently forgot a few things in bug 271720. These still check for attributes:
- nsXFormsControlStubBase::GetReadOnlyState()
- nsXFormsControlStubBase::GetRelevantState()
- nsXFormsDelegateStub::GetState() (and its friends)

They need to get to the nodestate from the model, which is not possible right
now. One approach is to expose the nsXFormsMDGEngine::GetNodeState(), which I
would go for now.

Another approach is to do the more versatile solution which is also wanted in
bug 313113, but let's wait with that.
Comment 1 User image Allan Beaufour 2005-10-21 10:20:35 PDT
Created attachment 200362 [details] [diff] [review]

Ok, this is no beauty, but if we want it in for 1.5rc1, this is what I can
supply right now. What should be tested is that delegate.isReadonly(),
delegate.isEnabled(), etc. work properly.

This should be done properly by the major overhaul of handling the states as I
write in bug 300591 comment 3.
Comment 2 User image Allan Beaufour 2005-10-22 08:21:56 PDT
Checked in to trunk
Comment 3 User image Allan Beaufour 2005-10-22 08:24:52 PDT
Checked in to 1.8 branch

Note You need to log in before you can comment on or make changes to this bug.