313213 - STEP_TIMEOUT causes too much GC's.

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (he/him)]

According to Silver, we need a larger value for client.STEP_TIMEOUT in order to
get a few less GC's in js. This change has already been made in CZ 0.9.68.5

Patch coming up.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Comment 2

[James Ross]

I should work out just how much GCing it caused, but I remember debugging the JS engine and wondering why it was doing a GC so frequently, and it turned out to be the ChatZilla loop.

It doesn't actually allocate a lot of memory, but it causes a lot of small things to be allocated then freed (local variables, call stack, etc.), and SpiderMonkey uses the amount of memory "churn" [1] as a trigger for GCing.

[1] The amount of memory allocated since the counter was reset, ignoring frees.

Comment 3

[James Ross]

Comment on attachment 200295 [details] [diff] [review]
Patch

r=silver

This will slow the client down, but since we already have the variable-speed code in at http://lxr.mozilla.org/seamonkey/source/extensions/irc/xul/content/static.js#1501 it should actually run at a decent speed still.

Comment 4

[Samuel Sieb]

checked in