313245 - MailNews Account Settings: duplicated accesskeys and more problems...

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051020 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051020 SeaMonkey/1.1a

The panel for setting up pop/imap servers has many duplicated accesskeys.
Moreover, there are so many entries that finding a suitable accesskey in
translations (l10n) becomes impossibile (eg. in Italian).
Can we simplify the panel or reduce the options in order to avoid collisions and
help localizers?


Reproducible: Always

Steps to Reproduce:
1. Open MailNews
2. Select Edit and choose Mail & Newsgroups Account Settings...
3. Click on any Sever Settings category of a mail account (problem is more
visible with POP accounts)

Comment 1

[Karsten Düsterloh]

Looking at the entire dialog with this panel shown, I see 23 active items - this
could be quite hard to tackle with just about 36 characters...

Comment 2

[[e-mail]]

And 4 duplicates too (a f l n) - that's not good :-(
Even the IMAP panel has two duplicates (a and n) and News duplicates f too...

Comment 3

[Aaron Lawrence]

(Looking at Moz 1.7.3, I assume it hasn't changed that much ...?)

I can't see why Local Directory belongs here; that eliminates 2 controls. It
more logically belongs in "Disk Space" (perhaps renaming that to "files" or
something).

You could also split off some of the "what to do with messages" stuff... perhaps
EMpty trash on Exit doesn't belong...

Comment 4

[Giacomo Magnini]

More duplicated accesskeys:
 - Copies & Folders (r)
 - Composition & Addressing (u)
 - Disk Space (a, r)

Comment 5

[Giacomo Magnini]

I have put some effort on a proposal for this (still work in progress, only screenshots) here:
http://www.portalis.it/tenutamontescosso/mozilla/proposal.html
Suggestions welcome.

Comment 6

[Ian Neal]

(In reply to comment #5)
> I have put some effort on a proposal for this (still work in progress, only
> screenshots) here:
> http://www.portalis.it/tenutamontescosso/mozilla/proposal.html
> Suggestions welcome.
> 
Thank you for that, some comments below:
a) I agree with "Default Character Encoding" moving from "Server Settings" pane to "Composition & Addressing" one though I only see this option on newsgroup servers not POP servers as you show.
b) Your IMAP account's new "Offline & Disk Space" pane is missing both the Offline bit and the local folder bit which I think means you would run out of space with your proposed changes.
c) Possible way round this would be just to move the local folder bit to the "Disk Space" / "Offline & Disk Space" pane
d) I don't think you should move the newsrc file location bit. (Your before shot is the same as your after shot at the moment!)
e) I don't think you need to get rid of the "Disk Space" pane for "Local Folders" but, at the moment, I think it is your choice.

That's all I think of at the moment.

Comment 7

[[e-mail]]

Default character encoding exists because news clients historically were less likely to use MIME character encoding headers. This means that when reading news you need to know which character encoding to read them in by default.

Comment 8

[Giacomo Magnini]

Ok, reporting my first findings.
I've tried to move Local Directory from server panel to (Offline &) Disk Space:
- It fits nicely for all kind of accounts! :)
- Local Folders gets 2 Local Directory in both its panels (some shuffling needed: probably am-serverwithnoidentities.xul should become am-offlinewithnoidentities.xul)
- There are many problems with js files and errors (will require much shuffling of functions and variables across various js files).
I'll try to see if it works better with "Copies & Folders", which is an as good solution as Disk Space.
After that, will try to move some of the delete message options from Server Settings panel to Disk Space (which is much more appropriate, IMHO).

I'm not going to attach any patch (a bit less spamming), but please ask if you want me to.

Comment 9

[Giacomo Magnini]

Again some reporting.
Moving Local Directory to Copies & Folders (on top, before the overlay, which seems a little overkill and useless to me) seems to be successful and requires no js shuffling around. Screenshot available if needed.

Will now see what implies moving the Empty Trash on Exit from Server panel to Disk Space panel.

Comment 10

[Giacomo Magnini]

More findings again.
Tried moving Empty Trash on Exit and Expunge Inbox on Exit (IMAP) to (Offline &) Disk Space and it looks nice, and it doesn't impact js files at all (no problems in the JS console).
I didn't find a good place where to stick the Advanced button (it is now at the bottom of the Server Settings box: any suggestion?

Since Def Char Encoding is strictly NNTP, I wouldn' move it from where it is.
This last experiment seems like a good way to, and maybe probably we can include also comment 9. You maildev masters, what do you think?

Comment 11

[Wayne Mery (:wsmwk)]

dupe bug 281642 to this one?

Comment 13

[Tony Mechelynck [:tonymec]]

Seamonkey-trunk Preferences UI are being ported to a different backend. I suppose Account Settings UI will be ported afterwards. I'm not sure if there's a meta bug for Account Settings yet, but I suppose these accesskey duplications should be kept in mind if & when.

Comment 14

[Giacomo Magnini]

Ok, after the migration there are a few accesskey duplication left (with suggestions, tested for POP, IMAP, News and movemail):

Server settings -> "_F_etch headers only" --> "F_e_tch headers only"
Copies & Folders -> ""Archives" Folder on" --> ""Archi_v_es" Folder on"
Synchronization & Storage (IMAP only) -> "_A_dvanced" --> "Ad_v_anced"
Synchronization & Storage (News only) -> "M_e_ssages more than" --> "Me_s_sages more than" (contestually: "_S_elect newsgroups for offline use" -> "Sele_c_t newsgroups for offline use")

It's no duplicate, but worth changing since it's hardly readable:
Security -> "Mana_g_e Security Device" --> "Manage Security De_v_ice"

PLEASE NOTE:
Copies & Folders has another duplicate ("O_t_her", used twice) which is impossible to solve, because all of the letters are already used. A good candidate for a rephrase?

PLEASE NOTE 2:
Under SM and TB a few accesskeys seem to be underlined twice (Server settings -> Server, Port for example). Is this another bug?

Since the duplicates also apply to Thunderbird 3.0b3, moving to MailNews Core and changing from Enhancement to normal priority bug / polish (late-l10n should be added?).

Comment 15

[Giacomo Magnini]

Adding Mark to the cc list since he maybe interested.
Probably the summary should be changed, and I'm not sure if the component and version fields are correct. Please fix them if they aren't, sorry.

Comment 16

[Giacomo Magnini]

Attachment: First attemp

Comment 17

[Phil Ringnalda (:philor)]

Why is archiveInOtherFolder.accesskey impossible to fix? I don't see anything using "h".

Comment 18

[Giacomo Magnini]

(In reply to comment #17)
> Why is archiveInOtherFolder.accesskey impossible to fix? I don't see anything
> using "h".

That may work for TB but not for SM...

Comment 19

[Phil Ringnalda (:philor)]

Ah, indeed, the help button. Shame about that, sure glad we don't have one ;)

Comment 20

[Phil Ringnalda (:philor)]

Comment on attachment 370603 [details] [diff] [review]
First attemp

Not sure what SeaMonkey wants to do (you might want to prod Mnyromyr into a decision by requesting review from him), but for Tb that would be fine with just the "h" accesskey for archiveInOtherFolder.

Comment 21

[Ian Neal]

I suppose one option is to change "Other:" to "Other Folder:" then have
<!ENTITY draftsFolderOn.accesskey "n">
<!ENTITY archivesFolderOn.accesskey "v">
<!ENTITY archiveInOtherFolder.accesskey "d">

Comment 22

[Giacomo Magnini]

Attachment: Patch for TB (as discussed with philor on IRC) - checked in

Comment 23

[Giacomo Magnini]

Attachment: Patch for SM, integrating IanN's suggestions (pushed)

Comment 24

[Phil Ringnalda (:philor)]

Comment on attachment 374750 [details] [diff] [review]
Patch for TB (as discussed with philor on IRC) - checked in

Looks good, thanks!

Comment 25

[Phil Ringnalda (:philor)]

Comment on attachment 374750 [details] [diff] [review]
Patch for TB (as discussed with philor on IRC) - checked in

http://hg.mozilla.org/comm-central/rev/66357335292f

Comment 26

[Giacomo Magnini]

Comment on attachment 374751 [details] [diff] [review]
Patch for SM, integrating IanN's suggestions (pushed)

Don't really like different files for TB and SM: phil, what about using the same strings as SM with this patch?
I guess I'll need Neil's sr as well...

Comment 27

[Stefan [:stefanh]]

Comment on attachment 374751 [details] [diff] [review]
Patch for SM, integrating IanN's suggestions (pushed)

http://hg.mozilla.org/comm-central/rev/59e078c087f9