[FIX] Combobox changes value if a reflow occurs while menu is dropped down

VERIFIED FIXED

Status

()

Core
Layout: Form Controls
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: mats)

Tracking

({fixed1.8, regression, testcase})

Trunk
x86
All
fixed1.8, regression, testcase
Points:
---
Bug Flags:
blocking1.8rc1 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
To reproduce:
- Visit url testcase, and follow the steps in the testcase

Afterwards, the selected option has become "1", it should have stayed "3".
Mozilla1.7 and IE6 both keep the selected option "3".
I very much suspect this is a regression from bug 286170 itself, since I can see
the bug also in a SeaMonkey 2005-07-11 build.
(Reporter)

Comment 1

12 years ago
This regressed between 2005-06-20 and 2005-06-22 and I've checked in my debug
build that bug 295571 isn't the cause of this/

Comment 2

12 years ago
The number hovered in the moment when 5 is removed, gets set as default option.
Load attachment 179320 [details], drop down the combobox menu and hover "2", and wait
until "5" gets removed. "5" can't be selected when "5" is removed, so the first
item gets selected.
(Assignee)

Comment 3

12 years ago
I get the same regression range. I backed out bug 286170 locally and still see
the bug though. I'll take a look...
Assignee: nobody → mats.palmgren
No longer blocks: 286170
(Assignee)

Updated

12 years ago
OS: Windows XP → All
(Assignee)

Comment 4

12 years ago
Regression is from bug 297389. It's quite bad actually, if we get a reflow
while the menu is dropped down we will select the item that is hovered by
the mouse. To reproduce:
1. click on any combobox (to drop down the menu)
2. hover an item different from the currently selected value
3. text zoom (CTRL++)  => combobox value changes to what was hovered
Blocks: 297389
Summary: Testcase 6 of bug 286170 has changed behavior → [FIX] Combobox changes value if a reflow occurs while menu is dropped down
(Assignee)

Comment 5

12 years ago
Created attachment 200412 [details] [diff] [review]
Patch rev. 1
Attachment #200412 - Flags: superreview?(roc)
Attachment #200412 - Flags: review?(roc)
Comment on attachment 200412 [details] [diff] [review]
Patch rev. 1

r+sr=bzbarsky.	Please check this in on trunk ASAP and request branch approval.
Attachment #200412 - Flags: superreview?(roc)
Attachment #200412 - Flags: superreview+
Attachment #200412 - Flags: review?(roc)
Attachment #200412 - Flags: review+
(Assignee)

Comment 7

12 years ago
Checked in to trunk at 2005-10-21 20:47 PDT.

-> FIXED
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: blocking1.8rc1?
Resolution: --- → FIXED
Attachment #200412 - Flags: approval1.8rc1?
This is a very safe fix that we should take on branch.  All it does is make sure
to not change what option is "selected" while the combobox is dropped down.

Comment 9

12 years ago
bz, what would we need to test to make sure this doesn't break anything else?
Modifications to combobox layout (text resize, DOM timeouts firing, etc) while the combobox is dropped down.  The dropped-down state is the only state affected.

Updated

12 years ago
Attachment #200412 - Flags: approval1.8rc1? → approval1.8rc1+

Updated

12 years ago
Flags: blocking1.8rc1? → blocking1.8rc1+
Checked in on branch.
Keywords: fixed1.8
(Reporter)

Comment 12

12 years ago
Verified.
Sorry for blaming the wrong bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.