31336 - [patch] separate bug groups from access groups in editusers.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Dave Miller [:justdave]]

The current situation: If you have more than one bug group (isbuggroup=1), it 

gets alphabetized in the list, and they're all mixed up with the access groups 

(isbuggroup=0), making them hard to tell apart without closely reading the 

descriptions.



My proposed enhancement: I think it would be a little cleaner-looking in 

editusers.cgi when viewing the user if the bug groups were listed separately from 

the access groups in the list, perhaps with an <HR> between them.  This gets all 

the bug groups grouped together, so you can easily distinguish them from the 

access groups.

Comment 1

[Dave Miller [:justdave]]

A related item to add onto this...  it does not make sense for a user to be able 
to move someone in and out of a particular group, yet the user themselves aren't 
in that group.  Yet this is easily possible to do with the double-checkbox 
situation.  Perhaps instead of two checkboxes for each group, there could be a 
single popup menu/dropdown list with three choices: "nonmember","member","member+
editor".  This would not only prevent the above situation, but would be an 
additional way to cut down on the clutter in that page.

Comment 2

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 3

[Dave Miller [:justdave]]

OK, I'm attaching a patch to fix this.  I stuck with the double-checkbox, but did 
reorganize them so they're side-by-side instead of on top of each other now.  
This also separates the group bits from the privilege bits, and presents them 
separately to the person doing the editing.

Comment 4

[Dave Miller [:justdave]]

Attachment: Diffs for edituser.cgi to separate group bits from priv bits

Comment 5

[Dave Miller [:justdave]]

This has a patch on it still waiting for evaluation....

Comment 6

[Dave Miller [:justdave]]

taking this...

Comment 7

[Dave Miller [:justdave]]

Took some minor tweaking because the patch was a little out of date, but it's 
tested and checked in now.

Comment 8

[Jon Robertson]

The patch contains two copies of the following line:

$curgrouptype = 1;

curgrouptype is not used anywhere else in the script.  So 1) why is it 
duplicated and 2) why is it in there at all?

Comment 9

[Dave Miller [:justdave]]

Hmm, when I originally put that together, I tried it the first time sticking an <
HR> between them each time the group changed.  Then I changed it to do two 
queries, and forgot to remove it.  You're right, they don't need to be there.

Comment 10

[Dave Miller [:justdave]]

ok, they're gone.

Comment 11

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 12

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product