Closed Bug 313489 Opened 19 years ago Closed 19 years ago

readOnly attribute should not persist between sessions

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

Details

Attachments

(1 file)

After a few days of testing, everyone seems to be agreed that it would be better for the readOnly attribute to be re-evaluated every time Sunbird/Lightning starts up.  The most common error would be a network failure, which would fix itself automatically.  Right now the user needs to manually remove the readOnly flag from the calendar in this case.
Attached patch use mReadOnly instead of pref — — Splinter Review
This switches from using prefs via the calmgr to simply storing in a module var.  This way we're always false by default, and only if we fail on a particular load will we become readOnly.  It also has the advantage of reducing the dependency of the providers on the calmgr.
Attachment #200518 - Flags: first-review?(mvl)
Comment on attachment 200518 [details] [diff] [review]
use mReadOnly instead of pref

r=mvl
Attachment #200518 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: