313680 - add missing TLS cipher suites to SSLTAP

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Alexei Volkov]

when testing with openssl ciphers, ssltap reports the following ciphers
in ciphers suite section of client handshake decoded message: 

            cipher_suites[1] = { 
                (0x0060) ????/????????/?????????/???

               }
   and
            cipher_suites[1] = { 
                (0x0061) ????/????????/?????????/???

               }

These ids correspond to the following ciphers:

    { 0x0060, "TLS_RSA_EXPORT1024_WITH_RC4_56_MD5" },
    { 0x0061, "TLS_RSA_EXPORT1024_WITH_RC2_CBC_56_MD5" },

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Alexei
I think this is a dup of a bug assigned to me.  
Please look for that bug and if you find it, mark this as a duplicate of that.
search for bugs with comments containing ssltap.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

I was thinking of bug 201138, which was marked fixed 2 years ago.
Alexei, 
Please submit a patch to bring ssltap's list of cipher suite names up to date.  
It might as well include all the defined SSL3/TLS cipher suites and not only
those implemented by NSS.  

Comment 3

[Alexei Volkov]

Attachment: fix

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 201566 [details] [diff] [review]
fix

r=nelson
This list is good, as far as it goes.  
I think we might also want to add names for 72-74, 79, 7c-7e, and 80-83.  
But you can add this list while digging for the rest of them.

Comment 5

[Alexei Volkov]

Attachment: more complete cipher list

patch includes names for 72-74, 79, 7c-7e, and 80-83 ids.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 202126 [details] [diff] [review]
more complete cipher list

r=nelson

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Please get a second review for the 3.11 branch.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Hmm.  It appears this patch is already in the NSS 3.11 branch.  
Thanks.